Bugzilla – Attachment 145939 Details for
Bug 32655
Variables showing in patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32655: Move phone and itiva variables into templates
Bug-32655-Move-phone-and-itiva-variables-into-temp.patch (text/plain), 3.31 KB, created by
Martin Renvoize (ashimema)
on 2023-02-01 13:22:37 UTC
(
hide
)
Description:
Bug 32655: Move phone and itiva variables into templates
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-02-01 13:22:37 UTC
Size:
3.31 KB
patch
obsolete
>From 16125d478a62b4323f6a159da35811abc2fc0bb5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 17 Jan 2023 18:42:28 +0000 >Subject: [PATCH] Bug 32655: Move phone and itiva variables into templates > >To test: >1. Go to a patron record or create a new one. >2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. >3. Notice the variables. >4. Apply patch >5. Try steps 1 & 2 again, no varibales. >6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. >7. Go to Administration > Patron categories and try step 6 there as well. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/includes/messaging-preference-form.inc | 4 ---- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 4 ++++ > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 3 +++ > 3 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >index 0638545742c..b27cc00af5f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >@@ -1,10 +1,6 @@ > [% USE Koha %] > <!-- snippet for form to set borrower and patron category messaging preferences --> > >-<script> >- var TalkingTechItivaPhoneNotification = [% Koha.Preference('TalkingTechItivaPhoneNotification') || 0 | html %]; >- var PhoneNotification = [% Koha.Preference('PhoneNotification') || 0 | html %]; >-</script> > <input type="hidden" name="modify" value="yes" /> > <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" /> > <table> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index 2bb5921b81b..5f56479aec4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -733,6 +733,10 @@ > </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] >+ <script> >+ var TalkingTechItivaPhoneNotification = [% Koha.Preference('TalkingTechItivaPhoneNotification') || 0 | html %]; >+ var PhoneNotification = [% Koha.Preference('PhoneNotification') || 0 | html %]; >+ </script> > [% Asset.js("js/admin-menu.js") | $raw %] > [% Asset.js("js/messaging-preference-form.js") | $raw %] > [% INCLUDE 'calendar.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index e3839d8206f..365b15600c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1930,6 +1930,9 @@ legend:hover { > [% END %] > $("#guarantor_template").hide(); > >+ var TalkingTechItivaPhoneNotification = [% Koha.Preference('TalkingTechItivaPhoneNotification') || 0 | html %]; >+ var PhoneNotification = [% Koha.Preference('PhoneNotification') || 0 | html %]; >+ > </script> > [% Asset.js("js/members.js") | $raw %] > [% Asset.js("js/messaging-preference-form.js") | $raw %] >-- >2.39.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32655
:
145363
|
145367
|
145374
| 145939