Attachment 145943 Details for Bug 32515 – Bug 32515: Ignore no-block flag in check-in message

[patch] Bug 32515: Ignore no-block flag in check-in message

Bug-32515-Ignore-no-block-flag-in-check-in-message.patch (text/plain), 2.04 KB, created by Martin Renvoize (ashimema) on 2023-02-01 13:43:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-02-01 13:43:57 UTC

Size: 2.04 KB

patch

obsolete

>From c7afa3fe237ebaebc8b627c2780d1c53c64c251f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 27 Dec 2022 20:32:10 +0000
>Subject: [PATCH] Bug 32515: Ignore no-block flag in check-in message
>
>Bug 12225 changed the templates to correctly pass through the no-block flag,
>however, we don't have a no-block routine for checkins
>
>This patch restore previous behaviour of performing a normal checkin when
>no block was requested - it adds a new FIXME
>
>To test:
>1 - See bug 32537
>    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
>2 - Repeat test plan on that bug, noting that there is no response when no-block = Y
>3 - Apply this patch
>4 - Repeat the tests and confirm no-block = Y has a standard checkin response
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Blou <philippe.blouin@inlibro.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/SIP/Sip/MsgType.pm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index cad82e0b35e..7ba61959a3c 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -672,8 +672,11 @@ sub handle_checkin {
>     if ( $no_block eq 'Y' ) {
> 
>         # Off-line transactions, ick.
>-        siplog( "LOG_WARNING", "received no-block checkin from terminal '%s'", $account->{id} );
>-        $status = $ils->checkin_no_block( $item_id, $trans_date, $return_date, $item_props, $cancel );
>+        siplog( "LOG_WARNING", "received no-block checkin from terminal '%s' - no-block checkin not supported", $account->{id} );
>+        #FIXME We need to write the routine called below
>+        #$status = $ils->checkin_no_block( $item_id, $trans_date, $return_date, $item_props, $cancel );
>+        #Until we do, lets just checkin the item
>+        $status = $ils->checkin( $item_id, $trans_date, $return_date, $my_branch, $item_props, $cancel, $account );
>     } else {
>         $status = $ils->checkin( $item_id, $trans_date, $return_date, $my_branch, $item_props, $cancel, $account );
>     }
>-- 
>2.39.1

Actions: View | Diff | Splinter Review

Attachments on bug 32515: 144856 | 144963 | 145370 | 145943