Bugzilla – Attachment 145969 Details for
Bug 32779
Import from list is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32779: ERM - Fix import from list
Bug-32779-ERM---Fix-import-from-list.patch (text/plain), 1.65 KB, created by
Pedro Amorim
on 2023-02-01 16:58:48 UTC
(
hide
)
Description:
Bug 32779: ERM - Fix import from list
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-02-01 16:58:48 UTC
Size:
1.65 KB
patch
obsolete
>From 81e8a01a4bb56849c6bb425067cb9d5fec0edf5d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 1 Feb 2023 14:06:27 +0100 >Subject: [PATCH] Bug 32779: ERM - Fix import from list > >There is a typo, '$' is missing, which caused the following error: >Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 > >Test plan: >Create a list, add an item >Turn on ERM >Create a package >Go to /cgi-bin/koha/erm/eholdings/local/titles >Click "Import from list" >Select the package, then your list, and import >It should succeed > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm b/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm >index c57c223312..c48181f34f 100644 >--- a/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm >+++ b/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm >@@ -124,7 +124,7 @@ sub process { > my ( $date_first_issue_online, $date_last_issue_online ) = > $fix_coverage->( $record->subfield( '866', 'a' ) ); > my ( $num_first_vol_online, $num_last_vol_online ) = >- fix_coverage->( $record->subfield( '863', 'a' ) ); >+ $fix_coverage->( $record->subfield( '863', 'a' ) ); > my ( $num_first_issue_online, $num_last_issue_online ) = > ( '', '' ); # FIXME ? > my $title_url = $record->subfield( '856', 'u' ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32779
:
145948
|
145949
|
145968
|
145969
|
145970
|
145971