Attachment 146138 Details for Bug 32872 – Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

[patch] Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Bug-32872-Fix-cataloguingvaluebuilderunimarcfield4.patch (text/plain), 1.58 KB, created by Julian Maurice on 2023-02-03 14:04:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2023-02-03 14:04:13 UTC

Size: 1.58 KB

patch

obsolete

>From c2c135052d95854fc90943abf10f7b3d87aac2a4 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:55 +0100
>Subject: [PATCH] Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>---
> cataloguing/value_builder/unimarc_field_4XX.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
>index 7b0ef28018..217a9f8e08 100755
>--- a/cataloguing/value_builder/unimarc_field_4XX.pl
>+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
>@@ -46,9 +46,9 @@ sub plugin_javascript {
>     my $function_name = $field_number;
>     my $res           = "
>     <script>
>-        function Clic$function_name(i) {
>-            defaultvalue=document.getElementById(\"$field_number\").value;
>-            window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=\" + i + \"&result=\"+defaultvalue,\"unimarc_field_4\"+i+\"\",'width=900,height=700,toolbar=false,scrollbars=yes');
>+        function Clic$function_name(event) {
>+            defaultvalue=document.getElementById(event.data.id).value;
>+            window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_4\"+event.data.id+\"\",'width=900,height=700,toolbar=false,scrollbars=yes');
> 
>         }
>     </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32872: 146138 | 146806 | 149003 | 150094