Bugzilla – Attachment 14619 Details for
Bug 9147
OPAC hidden fields are not hidden in ISBD view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9147: OPAC hidden fields are not hidden in ISBD view
SIGNED-OFF-Bug-9147-OPAC-hidden-fields-are-not-hid.patch (text/plain), 2.29 KB, created by
Katrin Fischer
on 2013-01-16 07:35:47 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9147: OPAC hidden fields are not hidden in ISBD view
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-01-16 07:35:47 UTC
Size:
2.29 KB
patch
obsolete
>From 5e570b807428815e0073e2179b67d65bed07f66d Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Mon, 26 Nov 2012 15:15:18 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 9147: OPAC hidden fields are not hidden in > ISBD view > >When in framework a subfield has a number > 0 in hidden, it his hidden in MARCview. >It should be hidden also in ISBD view. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Does what it says, hides hidden fields on the OPAC > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >All tests and QA script pass. > >To test: >1) Hide 245$b or another field from ISBD view in your MARC > framework by assigning a hidden value greater 0 >2) Check the different views in OPAC, the field should be hidden now from > - Labelled MARC view (as it was before this patch) > - ISBD view > It will still show up for plain MARC and XSLT views. >--- > C4/Biblio.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 7d28ccd..1b88286 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -956,6 +956,10 @@ sub GetISBDView { > # warn "ERROR IN ISBD DEFINITION at : $isbdfield" unless $fieldvalue; > # warn "FV : $fieldvalue"; > if ( $subfvalue ne "" ) { >+ # OPAC hidden subfield >+ next >+ if ( ( $template eq 'opac' ) >+ && ( $tagslib->{$fieldvalue}->{$subfvalue}->{'hidden'} || 0 ) > 0 ); > foreach my $field (@fieldslist) { > foreach my $subfield ( $field->subfield($subfvalue) ) { > my $calculated = $analysestring; >@@ -991,6 +995,10 @@ sub GetISBDView { > for my $i ( 0 .. $#subf ) { > my $valuecode = $subf[$i][1]; > my $subfieldcode = $subf[$i][0]; >+ # OPAC hidden subfield >+ next >+ if ( ( $template eq 'opac' ) >+ && ( $tagslib->{$fieldvalue}->{$subfieldcode}->{'hidden'} || 0 ) > 0 ); > my $subfieldvalue = GetAuthorisedValueDesc( $tag, $subf[$i][0], $subf[$i][1], '', $tagslib ); > my $tagsubf = $tag . $subfieldcode; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9147
:
13680
|
13681
|
13961
| 14619