Bugzilla – Attachment 146190 Details for
Bug 32290
ILL requests uses some wrong terminology
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32290: Fix terminology on ILL requests page
-Bug-32290-Fix-terminology-on-ILL-requests-page.patch (text/plain), 4.68 KB, created by
Katrin Fischer
on 2023-02-05 02:30:18 UTC
(
hide
)
Description:
Bug 32290: Fix terminology on ILL requests page
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-02-05 02:30:18 UTC
Size:
4.68 KB
patch
obsolete
>From 15c618b4bf7a9d4788fe2e8ebb49762d094bf01d Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 5 Feb 2023 03:18:05 +0100 >Subject: [PATCH] Bug 32290: Fix terminology on ILL requests page > >This makes some fixes for the terminology used in >the ill-requests.pl page: > >This item cannot be issued as it has no biblio record associated with it >> This item cannot be checkout out as there is no bibliographic record associated with it > >You must choose a branch >> You must choose a library > >View borrower details >> View patron details > >Test plan: >* You can set up ILL using the instructions on > https://wiki.koha-community.org/wiki/ILL_backends >* All strings will be located on the ILL request management page or > the ILL requests list >* Or... you could verify looking at the patch itself >--- > .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 69a34add77..9e63d27ed5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -150,7 +150,7 @@ > [% IF !whole.stage || whole.stage == 'form' %] > <h1 id="ill-issue-title">Issue requested item to [% INCLUDE 'patron-title.inc' patron = request.patron %]</h1> > [% IF !request.biblio_id || request.biblio_id.length == 0 %] >- <div class="alert">This item cannot be issued as it has no biblio record associated with it</div> >+ <div class="alert">This item cannot be checkout out as there is no bibliographic record associated with it</div> > [% END %] > [% IF whole.value.errors.itemcount %] > <div class="alert">The bibliographic record for this request has multiple items, it should only have one. Please fix this then try again.</div> >@@ -246,7 +246,7 @@ > [% END %] > [% END %] > [% IF whole.value.errors.branchcode %] >- <span class="required">You must choose a branch</span> >+ <span class="required">You must choose a library</span> > [% END %] > </li> > <li class="ill_checkout_due_date"> >@@ -619,7 +619,7 @@ > <li class="borrowernumber"> > <span class="label borrowernumber">Patron:</span> > [% borrowerlink = "/cgi-bin/koha/members/moremember.pl" _ "?borrowernumber=" _ request.patron.borrowernumber %] >- <a href="[% borrowerlink | url %]" title="View borrower details"> >+ <a href="[% borrowerlink | url %]" title="View patron details"> > [% request.patron.firstname _ " " _ request.patron.surname _ " [" _ request.patron.cardnumber _ "]" | html %] > </a> > </li> >@@ -673,7 +673,7 @@ > <p>[% request.notesstaff | html %]</p> > </li> > <li class="notesopac"> >- <span class="label notes_opac">Notes:</span> >+ <span class="label notes_opac">OPAC notes:</span> > <p>[% request.notesopac | html %]</p> > </li> > </ol> >@@ -749,7 +749,7 @@ > [% FOREACH comment IN request.illcomments %] > <div class="rows comment_[% comment.patron.categorycode | html %]"> > <h5>Comment by: >- <a href="[% borrowerlink | url %]" title="View borrower details"> >+ <a href="[% borrowerlink | url %]" title="View patron details"> > [% comment.patron.firstname _ " " _ comment.patron.surname _ " [" _ comment.patron.cardnumber _ "]" | html %]</a> > [% comment.timestamp | $KohaDates with_hours => 1 %]</h5> > <p>[% comment.comment | html %]</p> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32290
:
146189
|
146190
|
146278
|
146323