Bugzilla – Attachment 146204 Details for
Bug 32660
Use template wrapper for basket groups tabs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32660: Use template wrapper for basket groups tabs
Bug-32660-Use-template-wrapper-for-basket-groups-t.patch (text/plain), 3.71 KB, created by
Katrin Fischer
on 2023-02-05 12:46:07 UTC
(
hide
)
Description:
Bug 32660: Use template wrapper for basket groups tabs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-02-05 12:46:07 UTC
Size:
3.71 KB
patch
obsolete
>From 4562dc8ad804876d4f5f361624a448d4edc50f23 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 17 Jan 2023 19:58:55 +0000 >Subject: [PATCH] Bug 32660: Use template wrapper for basket groups tabs > >This patch implements the template WRAPPER system (see Bug 32571) for >building tabs on the basket groups page. > >To test you must have at least one active vendor, one or more closed >baskets under that vendor, and at least one basket group containing a >closed basket. > >Apply the patch and go to Acquisitions -> Vendor -> Basket groups. > >You should see two tabs, "Open" and "Closed." The tabs should look >correct and work correctly. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/acqui/basketgroup.tt | 26 ++++++++++--------- > 1 file changed, 14 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >index f7ef0c98e9..f4a8f49a70 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >@@ -328,13 +328,14 @@ > </div> > <h1>Basket grouping for <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% booksellername | html %]</a></h1> > [% IF (NoEDIMessage) %]<div><strong>No EDIFACT configuration for [% booksellername | html %]</strong></div>[% END %] >- <div id="basket_groups" class="toptabs"> >- <ul class="nav nav-tabs" role="tablist"> >- <li role="presentation"><a href="#opened" aria-controls="opened" role="tab" data-toggle="tab">Open</a></li> >- <li role="presentation"><a href="#closed" aria-controls="closed" role="tab" data-toggle="tab">Closed</a></li> >- </ul> >- <div class="tab-content"> >- <div role="tabpanel" class="tab-pane active" id="opened"> >+ >+ [% WRAPPER tabs id= "basket_groups" %] >+ [% WRAPPER tabs_nav %] >+ [% WRAPPER tab_item tabname= "opened" active= 1 %] Open [% END %] >+ [% WRAPPER tab_item tabname= "closed" %] Closed [% END %] >+ [% END %] >+ [% WRAPPER tab_panels %] >+ [% WRAPPER tab_panel tabname="opened" active= 1 %] > <table id="basket_group_opened"> > <thead> > <tr> >@@ -372,8 +373,9 @@ > [% END %] > </tbody> > </table> >- </div> >- <div role="tabpanel" class="tab-pane" id="closed"> >+ [% END #/opened %] >+ >+ [% WRAPPER tab_panel tabname="closed" %] > <table id="basket_group_closed"> > <thead> > <tr> >@@ -416,9 +418,9 @@ > [% END %] > </tbody> > </table> >- </div> >- </div> >- </div> >+ [% END #/closed %] >+ [% END # /WRAPPER tab_panels %] >+ [% END # /#basket_groups %] > [% END %] > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32660
:
145371
|
145538
|
145790
|
145791
| 146204 |
146205