Attachment 146263 Details for Bug 32803 – Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong

[patch] Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong

Bug-32803---EnableItemGroups-and-EnableItemGroupHo.patch (text/plain), 3.19 KB, created by Matt Blenkinsop on 2023-02-06 11:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2023-02-06 11:34:06 UTC

Size: 3.19 KB

patch

obsolete

>From fe8e57cf0b99a27e7c310db7652267e3f535271e Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Thu, 2 Feb 2023 12:45:04 -0500
>Subject: [PATCH] Bug 32803 - EnableItemGroups and EnableItemGroupHolds options
> are wrong
>
>This patch corrects the options for the EnableItemGroups and
>EnableItemGroupHolds system preferences.
>
>To test:
>1. Enable EnableItemGroups and EnableItemGroupHolds system preferences
>   1.1. Go to Administration > Global system preferences
>   1.2. Search for EnableItemGroup (no s, to get both)
>   1.3. Enable both EnableItemGroups and EnableItemGroupHolds
>   1.4. Click Save all Circulation preferences
>2. Go to About Koha > System information
>   --> There is a warning message
>3. Go to a bibliographic record with at least one item
>   --> The item group tab is displayed
>4. Create an item group
>   4.1. Click New item group
>   4.2. Enter a name
>   4.3. Click Submit
>   4.4. In the Holdings tab, select the item
>   4.5. Click on Add/move to item group
>   4.6. Click Set item group
>5. Place a hold on the item group
>   5.1. Click Place hold
>   5.2. Search for a patron
>   5.3. In the 'Hold next available item from an item group' section, select the item group
>   5.4. Click Place hold
>   --> Placing a hold is possible
>6. Disable EnableItemGroups and EnableItemGroupHolds system preferences
>   1.1. Go to Administration > Global system preferences
>   1.2. Search for EnableItemGroup (no s, to get both)
>   1.3. Disable both EnableItemGroups and EnableItemGroupHolds
>   1.4. Click Save all Circulation preferences
>7. Go to About Koha > System information
>   --> There is a warning message
>8. Apply patch
>9. Redo steps 1 and 2
>   --> There is no warning
>10. Redo step 3
>   --> The item group tab is displayed
>11. Redo steps 4 and 5
>   --> Placing a hold is possible
>12. Redo steps 6 and 7
>   --> There is no warning
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref    | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index e025fc6e9d0..51c9902db8f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -673,8 +673,8 @@ Circulation:
>         -
>             - pref: EnableItemGroups
>               choices:
>-                  yes: Enable
>-                  no: "Don't enable"
>+                  1: Enable
>+                  0: "Don't enable"
>             - the item groups feature to allow collecting groups of items on a record together.
>         -
>             - In the staff interface, split the holds queue into separate tables by
>@@ -688,8 +688,8 @@ Circulation:
>         -
>             - pref: EnableItemGroupHolds
>               choices:
>-                  yes: Enable
>-                  no: "Don't enable"
>+                  1: Enable
>+                  0: "Don't enable"
>             - the ability to place holds on item groups.
>         -
>             - If the holds queue is split, show librarians
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 32803: 146022 | 146263 | 147209