Attachment 146416 Details for Bug 32922 – Bug 32922: Remove space in shebang

[patch] Bug 32922: Remove space in shebang

Bug-32922-Remove-space-in-shebang.patch (text/plain), 5.81 KB, created by Magnus Enger on 2023-02-09 08:12:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2023-02-09 08:12:52 UTC

Size: 5.81 KB

patch

obsolete

>From 6ad5450148cf40aadbe269651ca3c825f381ca03 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Thu, 9 Feb 2023 08:57:25 +0100
>Subject: [PATCH] Bug 32922: Remove space in shebang
>
>Some of our scripts have a space in the "shebang" (first) line:
>
>This is not illegal, and it does work, but it is good to be
>consistent, so this patch removes the space.
>
>To test:
>- Run: grep -rn --include=*.pl '#! /usr/' *
>- See the list of files that have a space in the shebang
>- Apply the patch
>- Run the command again, there should be no output, meaning there
>  are no more files with space in the shebang
>- Have a look at the patch and check that it only changes the
>  shebangs
>- Sign off
>---
> admin/background_jobs.pl                      | 2 +-
> admin/cities.pl                               | 2 +-
> admin/classsources.pl                         | 2 +-
> admin/credit_types.pl                         | 2 +-
> admin/curbside_pickup.pl                      | 2 +-
> admin/debit_types.pl                          | 2 +-
> admin/desks.pl                                | 2 +-
> admin/library_groups.pl                       | 2 +-
> admin/matching-rules.pl                       | 2 +-
> admin/patron-attr-types.pl                    | 2 +-
> circ/curbside_pickups.pl                      | 2 +-
> erm/erm.pl                                    | 2 +-
> misc/add_statistics_borrowers_categorycode.pl | 2 +-
> misc/cronjobs/delete_items.pl                 | 2 +-
> misc/maintenance/check_syspref_cache.pl       | 2 +-
> misc/maintenance/compare_es_to_db.pl          | 2 +-
> 16 files changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/admin/background_jobs.pl b/admin/background_jobs.pl
>index b85281ce72..6eb05b0f82 100755
>--- a/admin/background_jobs.pl
>+++ b/admin/background_jobs.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/admin/cities.pl b/admin/cities.pl
>index f16c9d7a50..f8a4df6a13 100755
>--- a/admin/cities.pl
>+++ b/admin/cities.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN
> # Copyright 2015 Koha Development Team
>diff --git a/admin/classsources.pl b/admin/classsources.pl
>index 89b2200c64..59828be04e 100755
>--- a/admin/classsources.pl
>+++ b/admin/classsources.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> #
> # Copyright 2007 LibLime
> # Copyright 2018 Koha Development Team
>diff --git a/admin/credit_types.pl b/admin/credit_types.pl
>index 27f6edf2ad..c4a4920257 100755
>--- a/admin/credit_types.pl
>+++ b/admin/credit_types.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # Copyright 2020 Koha Development Team
> #
>diff --git a/admin/curbside_pickup.pl b/admin/curbside_pickup.pl
>index 528d846611..c4ccf467d9 100755
>--- a/admin/curbside_pickup.pl
>+++ b/admin/curbside_pickup.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/admin/debit_types.pl b/admin/debit_types.pl
>index 40210479a1..0b1546d8e5 100755
>--- a/admin/debit_types.pl
>+++ b/admin/debit_types.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # Copyright 2019 Koha Development Team
> #
>diff --git a/admin/desks.pl b/admin/desks.pl
>index bc087a3c9d..8f6bc7911d 100755
>--- a/admin/desks.pl
>+++ b/admin/desks.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # Copyright (C) 2020 BULAC
> #
>diff --git a/admin/library_groups.pl b/admin/library_groups.pl
>index 7bed778c27..dad58d4771 100755
>--- a/admin/library_groups.pl
>+++ b/admin/library_groups.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # Copyright 2016 ByWater Solutions
> #
>diff --git a/admin/matching-rules.pl b/admin/matching-rules.pl
>index 3cdbbb7b6f..b8827126f7 100755
>--- a/admin/matching-rules.pl
>+++ b/admin/matching-rules.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> #
> # Copyright 2007 LibLime
> #
>diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl
>index 2cf2bf6f3b..e89b892776 100755
>--- a/admin/patron-attr-types.pl
>+++ b/admin/patron-attr-types.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> #
> # Copyright 2008 LibLime
> # Parts copyright 2010 BibLibre
>diff --git a/circ/curbside_pickups.pl b/circ/curbside_pickups.pl
>index dfef0af40c..a2e06d78ca 100755
>--- a/circ/curbside_pickups.pl
>+++ b/circ/curbside_pickups.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/erm/erm.pl b/erm/erm.pl
>index 9118a7336e..df841c98bd 100755
>--- a/erm/erm.pl
>+++ b/erm/erm.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/misc/add_statistics_borrowers_categorycode.pl b/misc/add_statistics_borrowers_categorycode.pl
>index 69e27de3cd..4099a9cafe 100755
>--- a/misc/add_statistics_borrowers_categorycode.pl
>+++ b/misc/add_statistics_borrowers_categorycode.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> ## EXTRACTED USING THIS:
> # grep -Pnir "'notforloan' => '6'" 01_items0* | grep -Po "'id' => '-?(\d+)'" | grep -Po "\d+" > itemnumbers_notforloan_6.txt
>diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl
>index 2eab937b21..4473ca51ab 100755
>--- a/misc/cronjobs/delete_items.pl
>+++ b/misc/cronjobs/delete_items.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/misc/maintenance/check_syspref_cache.pl b/misc/maintenance/check_syspref_cache.pl
>index 9328988baf..18be7926e6 100755
>--- a/misc/maintenance/check_syspref_cache.pl
>+++ b/misc/maintenance/check_syspref_cache.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> 
> # This file is part of Koha.
> #
>diff --git a/misc/maintenance/compare_es_to_db.pl b/misc/maintenance/compare_es_to_db.pl
>index 6eaea29799..2fb67e3629 100755
>--- a/misc/maintenance/compare_es_to_db.pl
>+++ b/misc/maintenance/compare_es_to_db.pl
>@@ -1,4 +1,4 @@
>-#! /usr/bin/perl
>+#!/usr/bin/perl
> #
> # This compares record counts from a Koha database to Elasticsearch
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32922: 146416 | 146417 | 146419 | 146498 | 146499 | 147193