Bugzilla – Attachment 146419 Details for
Bug 32922
Remove space in shebang
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32922: Remove space in shebang
Bug-32922-Remove-space-in-shebang.patch (text/plain), 5.95 KB, created by
Matt Blenkinsop
on 2023-02-09 09:27:44 UTC
(
hide
)
Description:
Bug 32922: Remove space in shebang
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-02-09 09:27:44 UTC
Size:
5.95 KB
patch
obsolete
>From fe4730d6ab9d5ccbd69d1ca4d94d4d071da53671 Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@libriotech.no> >Date: Thu, 9 Feb 2023 08:57:25 +0100 >Subject: [PATCH] Bug 32922: Remove space in shebang > >Some of our scripts have a space in the "shebang" (first) line: > > #! /usr/bin/perl > >This is not illegal, and it does work, but it is good to be >consistent, so this patch removes the space. > >To test: >- Run: grep -rn --include=*.pl '#! /usr/' * >- See the list of files that have a space in the shebang >- Apply the patch >- Run the command again, there should be no output, meaning there > are no more files with space in the shebang >- Have a look at the patch and check that it only changes the > shebangs >- Sign off > >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > admin/background_jobs.pl | 2 +- > admin/cities.pl | 2 +- > admin/classsources.pl | 2 +- > admin/credit_types.pl | 2 +- > admin/curbside_pickup.pl | 2 +- > admin/debit_types.pl | 2 +- > admin/desks.pl | 2 +- > admin/library_groups.pl | 2 +- > admin/matching-rules.pl | 2 +- > admin/patron-attr-types.pl | 2 +- > circ/curbside_pickups.pl | 2 +- > erm/erm.pl | 2 +- > misc/add_statistics_borrowers_categorycode.pl | 2 +- > misc/cronjobs/delete_items.pl | 2 +- > misc/maintenance/check_syspref_cache.pl | 2 +- > misc/maintenance/compare_es_to_db.pl | 2 +- > 16 files changed, 16 insertions(+), 16 deletions(-) > >diff --git a/admin/background_jobs.pl b/admin/background_jobs.pl >index b85281ce723..6eb05b0f827 100755 >--- a/admin/background_jobs.pl >+++ b/admin/background_jobs.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/admin/cities.pl b/admin/cities.pl >index f16c9d7a50f..f8a4df6a136 100755 >--- a/admin/cities.pl >+++ b/admin/cities.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN > # Copyright 2015 Koha Development Team >diff --git a/admin/classsources.pl b/admin/classsources.pl >index 89b2200c647..59828be04eb 100755 >--- a/admin/classsources.pl >+++ b/admin/classsources.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > # > # Copyright 2007 LibLime > # Copyright 2018 Koha Development Team >diff --git a/admin/credit_types.pl b/admin/credit_types.pl >index 27f6edf2ad6..c4a49202570 100755 >--- a/admin/credit_types.pl >+++ b/admin/credit_types.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # Copyright 2020 Koha Development Team > # >diff --git a/admin/curbside_pickup.pl b/admin/curbside_pickup.pl >index 528d8466116..c4ccf467d9e 100755 >--- a/admin/curbside_pickup.pl >+++ b/admin/curbside_pickup.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/admin/debit_types.pl b/admin/debit_types.pl >index 40210479a1f..0b1546d8e57 100755 >--- a/admin/debit_types.pl >+++ b/admin/debit_types.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # Copyright 2019 Koha Development Team > # >diff --git a/admin/desks.pl b/admin/desks.pl >index bc087a3c9de..8f6bc7911d8 100755 >--- a/admin/desks.pl >+++ b/admin/desks.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # Copyright (C) 2020 BULAC > # >diff --git a/admin/library_groups.pl b/admin/library_groups.pl >index 7bed778c277..dad58d47713 100755 >--- a/admin/library_groups.pl >+++ b/admin/library_groups.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # Copyright 2016 ByWater Solutions > # >diff --git a/admin/matching-rules.pl b/admin/matching-rules.pl >index 3cdbbb7b6f3..b8827126f71 100755 >--- a/admin/matching-rules.pl >+++ b/admin/matching-rules.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > # > # Copyright 2007 LibLime > # >diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl >index 2cf2bf6f3be..e89b8927765 100755 >--- a/admin/patron-attr-types.pl >+++ b/admin/patron-attr-types.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > # > # Copyright 2008 LibLime > # Parts copyright 2010 BibLibre >diff --git a/circ/curbside_pickups.pl b/circ/curbside_pickups.pl >index dfef0af40c3..a2e06d78ca6 100755 >--- a/circ/curbside_pickups.pl >+++ b/circ/curbside_pickups.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/erm/erm.pl b/erm/erm.pl >index 9118a7336ee..df841c98bda 100755 >--- a/erm/erm.pl >+++ b/erm/erm.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/misc/add_statistics_borrowers_categorycode.pl b/misc/add_statistics_borrowers_categorycode.pl >index 69e27de3cdb..4099a9cafe8 100755 >--- a/misc/add_statistics_borrowers_categorycode.pl >+++ b/misc/add_statistics_borrowers_categorycode.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > ## EXTRACTED USING THIS: > # grep -Pnir "'notforloan' => '6'" 01_items0* | grep -Po "'id' => '-?(\d+)'" | grep -Po "\d+" > itemnumbers_notforloan_6.txt >diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl >index 2eab937b210..4473ca51abf 100755 >--- a/misc/cronjobs/delete_items.pl >+++ b/misc/cronjobs/delete_items.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/misc/maintenance/check_syspref_cache.pl b/misc/maintenance/check_syspref_cache.pl >index 9328988baf1..18be7926e6f 100755 >--- a/misc/maintenance/check_syspref_cache.pl >+++ b/misc/maintenance/check_syspref_cache.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > > # This file is part of Koha. > # >diff --git a/misc/maintenance/compare_es_to_db.pl b/misc/maintenance/compare_es_to_db.pl >index 6eaea297994..2fb67e3629f 100755 >--- a/misc/maintenance/compare_es_to_db.pl >+++ b/misc/maintenance/compare_es_to_db.pl >@@ -1,4 +1,4 @@ >-#! /usr/bin/perl >+#!/usr/bin/perl > # > # This compares record counts from a Koha database to Elasticsearch > >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32922
:
146416
|
146417
|
146419
|
146498
|
146499
|
147193