Attachment 146464 Details for Bug 31057 – Bug 31057: Add hint to the 'To date' input on the calendar form

[patch] Bug 31057: Add hint to the 'To date' input on the calendar form

Bug-31057-Add-hint-to-the-To-date-input-on-the-cal.patch (text/plain), 2.42 KB, created by Matt Blenkinsop on 2023-02-10 09:14:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2023-02-10 09:14:53 UTC

Size: 2.42 KB

patch

obsolete

>From f56db197b1b7f17fa4db0afd0e3895b2b6dd2a7c Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 9 Feb 2023 22:36:13 +0000
>Subject: [PATCH] Bug 31057: Add hint to the 'To date' input on the calendar
> form
>
>Just adding a hint using the 'hint' class didn't work as
>expected here. The hint was immediately hidden. That is
>because of the collapsable hint text for the option at
>the bottom of the form using the [?] link. So I chose to
>use the class of the [$] to make the script a little more
>selective.
>
>To test:
>* Go to the calendar tool
>* Test that the [$] hide/show different help texts
>* Apply patch
>* Verify a hint now shows below the "To date"
>* Verify that the help texts still function as before
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>index 7cf6e11e922..a5800decbb2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>@@ -175,6 +175,7 @@
>                                             <li class="dateinsert">
>                                                 <strong>To date: </strong>
>                                                 <input type="text" id="dateofrange" name="dateofrange" size="20" value="[% dateofrange | html %]" class="flatpickr" />
>+                                                <div class="hint">This field only applies when holidays are added on a range.</div>
>                                             </li>
>                                             <li>
>                                                 <label for="title">Title: </label>
>@@ -578,7 +579,7 @@
> 
>         $(document).ready(function() {
> 
>-            $(".hint").hide();
>+            $(".helptext + .hint").hide();
>             $("#branch").change(function(){
>                 changeBranch();
>             });
>@@ -606,7 +607,7 @@
>             });
> 
>             $("a.helptext").click(function(){
>-                $(this).parent().find(".hint").toggle(); return false;
>+                $(this).parent().find(".helptext + .hint").toggle(); return false;
>             });
> 
>             const dateofrange = document.querySelector("#dateofrange")._flatpickr;
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 31057: 146460 | 146464 | 148318