Bugzilla – Attachment 146467 Details for
Bug 32934
SIP checkouts using "no block" flag have a calculated due rather than the specified due date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32934: Correctly honor the no block due date for SIP checkout messages
Bug-32934-Correctly-honor-the-no-block-due-date-fo.patch (text/plain), 2.33 KB, created by
Kyle M Hall (khall)
on 2023-02-10 11:42:49 UTC
(
hide
)
Description:
Bug 32934: Correctly honor the no block due date for SIP checkout messages
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-02-10 11:42:49 UTC
Size:
2.33 KB
patch
obsolete
>From 732cd4a6ca84fbc5d069cd127a2a15bc755c63a7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 9 Feb 2023 14:56:01 -0500 >Subject: [PATCH] Bug 32934: Correctly honor the no block due date for SIP > checkout messages > >--- > C4/Circulation.pm | 10 +++++----- > C4/SIP/ILS/Transaction/Checkout.pm | 6 ++++-- > 2 files changed, 9 insertions(+), 7 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 5255c69e26b..9e6b70d0caf 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -4027,7 +4027,7 @@ sub ProcessOfflineOperation { > if ( $operation->{action} eq 'return' ) { > $report = ProcessOfflineReturn( $operation ); > } elsif ( $operation->{action} eq 'issue' ) { >- $report = ProcessOfflineIssue( $operation ); >+ ( $report ) = ProcessOfflineIssue( $operation ); > } elsif ( $operation->{action} eq 'payment' ) { > $report = ProcessOfflinePayment( $operation ); > } >@@ -4085,15 +4085,15 @@ sub ProcessOfflineIssue { > $operation->{timestamp}, > ); > } >- AddIssue( >+ my $checkout = AddIssue( > $patron->unblessed, >- $operation->{'barcode'}, >- undef, >+ $operation->{barcode}, >+ $operation->{due_date}, > undef, > $operation->{timestamp}, > undef, > ); >- return "Success."; >+ return ( "Success.", $checkout ); > } else { > return "Borrower not found."; > } >diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm >index d9056f1c824..109cc3eb064 100644 >--- a/C4/SIP/ILS/Transaction/Checkout.pm >+++ b/C4/SIP/ILS/Transaction/Checkout.pm >@@ -134,11 +134,13 @@ sub do_checkout { > > if ( $no_block_due_date ) { > $overridden_duedate = $no_block_due_date; >- ProcessOfflineIssue({ >+ my ( $msg, $checkout ) = ProcessOfflineIssue({ > cardnumber => $patron->cardnumber, > barcode => $barcode, >- timestamp => $no_block_due_date, >+ due_date => $no_block_due_date, >+ timestamp => dt_from_string, > }); >+ $self->{due} = $self->duedatefromissue($checkout, $itemnumber); > } else { > # can issue > my $issue = AddIssue( $patron->unblessed, $barcode, $overridden_duedate, 0 ); >-- >2.39.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32934
:
146450
|
146467
|
162737
|
172389
|
172399
|
172566
|
172567