Attachment 146501 Details for Bug 11844 – Bug 11844: Fix QA issues (POD, TT filters, file exec flag)

[patch] Bug 11844: Fix QA issues (POD, TT filters, file exec flag)

Bug-11844-Fix-QA-issues-POD-TT-filters-file-exec-f.patch (text/plain), 2.95 KB, created by Katrin Fischer on 2023-02-10 16:46:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-02-10 16:46:46 UTC

Size: 2.95 KB

patch

obsolete

>From e0a1b5b48868a433bb6be2342fbf7eb13ab0733a Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 20 Jan 2023 17:29:40 +0100
>Subject: [PATCH] Bug 11844: Fix QA issues (POD, TT filters, file exec flag)
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> Koha/AdditionalField.pm                           | 11 +++++++++++
> Koha/Template/Plugin/ClassSources.pm              | 15 +++++++++++++++
> installer/data/mysql/atomicupdate/bug-11844.pl    |  0
> .../prog/en/includes/additional-fields-entry.inc  |  2 +-
> 4 files changed, 27 insertions(+), 1 deletion(-)
> mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug-11844.pl
>
>diff --git a/Koha/AdditionalField.pm b/Koha/AdditionalField.pm
>index 12b0934f78..77a43724cc 100644
>--- a/Koha/AdditionalField.pm
>+++ b/Koha/AdditionalField.pm
>@@ -13,6 +13,17 @@ use base qw(Koha::Object);
> use C4::Context;
> use Koha::MarcSubfieldStructures;
> 
>+=head1 METHODS
>+
>+=head2 effective_authorised_value_category
>+
>+Returns the authorised value category of the additional field or the authorised
>+value category of the MARC field, if any.
>+
>+    my $av_category = $additional_field->effective_authorised_value_category;
>+
>+=cut
>+
> sub effective_authorised_value_category {
>     my ($self) = @_;
> 
>diff --git a/Koha/Template/Plugin/ClassSources.pm b/Koha/Template/Plugin/ClassSources.pm
>index 7b424f4905..81063e7acd 100644
>--- a/Koha/Template/Plugin/ClassSources.pm
>+++ b/Koha/Template/Plugin/ClassSources.pm
>@@ -22,6 +22,21 @@ use base qw( Template::Plugin );
> use C4::Context;
> use Koha::ClassSources;
> 
>+=head1 NAME
>+
>+Koha::Template::Plugin::ClassSources - Template::Toolkit plugin for Koha Classification Source Object
>+
>+=head1 METHODS
>+
>+=head2 all
>+
>+Return the list of class sources
>+
>+    [% class_sources = ClassSources.all() %]
>+    [% class_sources = ClassSources.all({ selected => $selected }) %]
>+
>+=cut
>+
> sub all {
>     my ($self, $params) = @_;
> 
>diff --git a/installer/data/mysql/atomicupdate/bug-11844.pl b/installer/data/mysql/atomicupdate/bug-11844.pl
>old mode 100644
>new mode 100755
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
>index b16f537090..3b93ad2d04 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
>@@ -61,7 +61,7 @@
>                 [% IF field.marcfield && field.marcfield_mode == 'get' %]
>                     This value will be filled with the [% field.marcfield | html %] subfield of the selected biblio.
>                 [% ELSIF field.marcfield && field.marcfield_mode == 'set' %]
>-                    This value will be saved to the [% field.marcfield %] subfield of the selected biblio.
>+                    This value will be saved to the [% field.marcfield | html %] subfield of the selected biblio.
>                 [% END %]
>             </li>
>         [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 11844: 25632 | 25638 | 41859 | 41860 | 45674 | 45675 | 45676 | 45758 | 45915 | 45916 | 45917 | 53614 | 53615 | 53616 | 53618 | 53619 | 55529 | 75332 | 75362 | 141116 | 145517 | 145535 | 145536 | 145540 | 146497 | 146500 | 146501 | 146502 | 146503 | 146504 | 146505 | 146506 | 148889 | 148895 | 148897 | 149081 | 149082 | 149083 | 149084 | 149085 | 149086 | 149087 | 149088 | 149089 | 149090 | 149091 | 149682 | 149683 | 149684 | 149685 | 149686 | 149687 | 149688 | 149689 | 149690 | 149691 | 149692 | 150537 | 150538 | 150539 | 150540 | 150541 | 150542 | 150543 | 150544 | 150545 | 150546 | 150547 | 150548 | 151220 | 151221 | 151222 | 151223 | 151224 | 151225 | 151226 | 151227 | 151228 | 151229 | 151230 | 151366