Attachment 146507 Details for Bug 31056 – Bug 31056: Restore closeandprint function on basketgroups page

[patch] Bug 31056: Restore closeandprint function on basketgroups page

Bug-31056-Restore-closeandprint-function-on-basket.patch (text/plain), 2.26 KB, created by Caroline Cyr La Rose on 2023-02-10 16:58:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2023-02-10 16:58:06 UTC

Size: 2.26 KB

patch

obsolete

>From 51af9bf4197ae94c58e6262fab4c4583be5bf52d Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 9 Feb 2023 23:57:12 +0100
>Subject: [PATCH] Bug 31056: Restore closeandprint function on basketgroups
> page
>
>Bug 13614 removed the basketgroup.js asset from the basket group
>page. This file includes the closeandprint function used for
>closing and printing the PDF from the open basket groups tab.
>The patch restores just this function directly in the file where
>it's needed as this is the only spot and it's only a few lines.
>The rest of basketgroup.js appears unused.
>
>To test:
>* Create a basket with one or more oder lines
>* Close the basket and check the checkbox to add it to a
>  basket group
>* Reopen the basket group from the basket groups page
>* Verify the close and print only leads to a JS error and
>  nothing happens
>* Apply patch
>* Repeat and verify you can now 'Close and print' from the
>  open basket group tab
>* Verify all other buttons work as expected as well
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> .../intranet-tmpl/prog/en/modules/acqui/basketgroup.tt   | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>index e298adf7e0..be9b9dfe0e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>@@ -7,7 +7,6 @@
> [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'datatables.inc' %]
> <script>
>-
>     var MSG_CONFIRM_CLOSE_BASKETGROUP = _("Are you sure you want to close this basketgroup?");
>     var MSG_CLOSE_EMPTY_BASKET = _("Why close an empty basket?");
>     var MSG_SAVE_BEFORE_PRINTING = _("You need to save the page before printing");
>@@ -24,6 +23,14 @@
>         }
>     }
> 
>+    function closeandprint(bg){
>+        if(document.location = '/cgi-bin/koha/acqui/basketgroup.pl?op=closeandprint&amp;basketgroupid=' + bg ){
>+            setTimeout("window.location.reload();",3000);
>+        }else{
>+        alert(MSG_FILE_DOWNLOAD_ERROR);
>+        }
>+    }
>+
>     $(document).ready(function() {
>         [% IF ( listclosed) %]
>             $("#basket_groups a[href='#closed']").tab("show");
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31056: 146461 | 146507 | 147192