Bugzilla – Attachment 146517 Details for
Bug 32353
reserves.item_group_id should be undefined in tests by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32353: Don't generate item group for holds in tests
Bug-32353-Dont-generate-item-group-for-holds-in-te.patch (text/plain), 1.44 KB, created by
Kyle M Hall (khall)
on 2023-02-10 19:38:50 UTC
(
hide
)
Description:
Bug 32353: Don't generate item group for holds in tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-02-10 19:38:50 UTC
Size:
1.44 KB
patch
obsolete
>From e4040a2fb8ca096ec5e4de9fa5f1782c37f4cf9a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 25 Nov 2022 13:06:40 +0100 >Subject: [PATCH] Bug 32353: Don't generate item group for holds in tests > >See bug 31447, we don't want the tests to deal with potential failures >because of some item groups. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 1 - > t/lib/TestBuilder.pm | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 2ecb44bec4..35e4d91a0f 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -5767,7 +5767,6 @@ subtest "CanBookBeIssued + needsconfirmation message" => sub { > priority => 1, > found => undef, > suspend => 0, >- item_group_id => $item->item_group > }}); > > my ( $error, $needsconfirmation, $alerts, $messages ); >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index 015d7bbd9a..8f8d79699a 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -602,7 +602,8 @@ sub _gen_default_values { > pickup_location => 0, > }, > Reserve => { >- non_priority => 0, >+ non_priority => 0, >+ item_group_id => undef, > }, > Itemtype => { > rentalcharge => 0, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32353
:
144253
|
144254
|
144255
|
144279
|
144957
|
144958
|
146516
| 146517 |
147191