Attachment 146526 Details for Bug 32525 – Bug 32525: Standardize labels on list of ILL requests and ILL request details page

[patch] Bug 32525: Standardize labels on list of ILL requests and ILL request details page

Bug-32525-Standardize-labels-on-list-of-ILL-reques.patch (text/plain), 4.38 KB, created by Katrin Fischer on 2023-02-10 23:03:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-02-10 23:03:50 UTC

Size: 4.38 KB

patch

obsolete

>From fb6ec1b955a0f95f5211051a873d0b5d12b9804e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 10 Feb 2023 23:57:44 +0100
>Subject: [PATCH] Bug 32525: Standardize labels on list of ILL requests and ILL
> request details page
>
>This changes some labels so they match up between the
>ILL requests list and the detail page of a request:
>
>* 'View biblio details' to 'View bibliographic record'
>* 'View borrower details' to 'View patron details'
>* 'Branch' table heading to 'Library' in list view
>* 'Request number' to 'Request ID' in list view
>* 'Type' to 'Request type' in detail view
>* 'Bibliographic record' to 'Bibliographic record ID"
>
>To test:
>*  Install a backend and activate the ILL module, see:
>   https://wiki.koha-community.org/wiki/ILL_backends
>*  Add a new request
>*  Compare the table headings with the labels on the detail page
>*  Apply patch
>*  Verify listed changes from above
>---
> .../prog/en/includes/ill-list-table-strings.inc             | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc | 6 +++---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
>index 4d217023c2..7734384155 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
>@@ -1,7 +1,7 @@
> 
> <script>
>-    var ill_borrower_details = _("View borrower details");
>-    var ill_biblio_details = _("View biblio details");
>+    var ill_borrower_details = _("View patron details");
>+    var ill_biblio_details = _("View bibliographic record");
>     var ill_statuses = {
>         new: _("New request"),
>         req: _("Requested"),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
>index 7b370937ce..7a08e0e211 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
>@@ -14,11 +14,11 @@
>                 <th scope="col">Volume</th>
>                 <th scope="col">Year</th>
>                 <th scope="col">Pages</th>
>-                <th scope="col">Type</th>
>+                <th scope="col">Request type</th>
>                 <th scope="col">Order ID</th>
>                 <th scope="col">Patron</th>
>-                <th scope="col">Bibliographic record</th>
>-                <th scope="col">Branch</th>
>+                <th scope="col">Bibliographic record ID</th>
>+                <th scope="col">Library</th>
>                 <th scope="col">Status</th>
>                 <th scope="col" class="placed">&nbsp;</th>
>                 <th scope="col" class="placed_formatted">Placed on</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 5e6c7fc0dd..0a6f423f7c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -450,7 +450,7 @@
>                                     <input name="price_paid" id="price_paid" type="text" value="[% request.price_paid | html %]">
>                                 </li>
>                                 <li class="req_id">
>-                                    <label class="req_id">Request number:</label>
>+                                    <label class="req_id">Request ID:</label>
>                                     [% request.id_prefix _ request.illrequest_id | html %]
>                                 </li>
>                                 <li class="notesstaff">
>@@ -665,7 +665,7 @@
>                                         [% IF request.price_paid %][% request.price_paid | $Price %][% ELSE %]<span>N/A</span>[% END %]
>                                     </li>
>                                     <li class="req_id">
>-                                        <span class="label req_id">Request number:</span>
>+                                        <span class="label req_id">Request ID:</span>
>                                         [% request.id_prefix _ request.illrequest_id | html %]
>                                     </li>
>                                     <li class="notesstaff">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32525: 146526 | 146582 | 147239