Attachment 146578 Details for Bug 32452 – Bug 32452: Link basket group on basket summary to basket groups page

[patch] Bug 32452: Link basket group on basket summary to basket groups page

Bug-32452-Link-basket-group-on-basket-summary-to-b.patch (text/plain), 2.95 KB, created by Owen Leonard on 2023-02-13 13:10:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-02-13 13:10:11 UTC

Size: 2.95 KB

patch

obsolete

>From a6c17fccc42aee4b64b2d964cc21cf5749f52ab4 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 10 Feb 2023 21:59:40 +0000
>Subject: [PATCH] Bug 32452: Link basket group on basket summary to basket
> groups page
>
>In most places we already link the basket group name to the
>basket group page, but not on the basket summary page.
>
>To test:
>* Create a basket/order with some order lines
>* Close the basket and check the checkbox for creating a basket group
>* Go back to the basket/order page
>* There will be a link 'Manage basket group', but the basket group name
>  is only text
>* Apply patch
>* Reload the page, the basket group name should now be linked
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 99f92d2f5f..c9952b04ea 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -386,14 +386,16 @@
>                                                                     [% END %]
>                                                                 [% ELSIF ( ! CAN_user_acquisition_group_manage ) %]
>                                                                     [%- IF basketgroup.id -%]
>-                                                                [% basketgroup.name | html %]
>+                                                                        [% basketgroup.name | html %]
>                                                                     [%- ELSE -%]
>                                                                         <span>No group</span>
>                                                                     [%- END -%]
>                                                                 [% ELSE %]
>                                                                     [% IF ( CAN_user_acquisition_group_manage ) %]
>                                                                         [% IF ( basketgroup.id ) %]
>-                                                                            [% basketgroup.name | html %]
>+                                                                            <a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% basket.booksellerid | uri %]&amp;basketgroupid=[% basketgroup.id | uri %]">
>+                                                                                [% basketgroup.name | html %]
>+                                                                            </a>
>                                                                             <a href="#" id="set_basket_group"><i class="fa fa-pencil"></i> Change basket group</a>
>                                                                         [% ELSE %]
>                                                                             No group
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32452: 146521 | 146578 | 147219