Attachment 146588 Details for Bug 32946 – Bug 32946: 'Send list' form in OPAC is misaligned

[patch] Bug 32946: 'Send list' form in OPAC is misaligned

Bug-32946-Send-list-form-in-OPAC-is-misaligned.patch (text/plain), 2.96 KB, created by Owen Leonard on 2023-02-13 16:06:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-02-13 16:06:54 UTC

Size: 2.96 KB

patch

obsolete

>From be82239d10758bc054311fa6f4c3c95bd59b8f2b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 13 Feb 2023 16:02:28 +0000
>Subject: [PATCH] Bug 32946: 'Send list' form in OPAC is misaligned
>
>This patch tweaks the OPAC CSS and the send list template so that form
>fields are laid out correctly.
>
>To test, apply the patch and rebuild the OPAC CSS.
>
>- Log in to the OPAC and create a list if necessary.
>- In the OPAC's view of the list contents, click the "Send list" button.
>- In the pop-up window the form layout should look correct.
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss          | 9 +++++++++
> .../opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt | 8 ++++----
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index a927bff544..719ef61980 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -1003,6 +1003,15 @@ fieldset {
>         }
>     }
> 
>+    &.brief {
>+        label {
>+            display: block;
>+            font-weight: bold;
>+            padding: .3em 0;
>+            text-align: left;
>+        }
>+    }
>+
>     table {
>         font-size: 100%;
>     }
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt
>index b7eb7d7fb8..a446e8b5a9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt
>@@ -31,13 +31,13 @@
>                                 <p><a class="button close" href="/cgi-bin/koha/opac-shelves.pl?op=view&amp;shelfnumber=[% shelfid | html %]">Back to lists</a></p>
>                             [% ELSE %]
>                                 <form action="/cgi-bin/koha/opac-sendshelf.pl" method="post" id="sendshelfform">
>-                                    <legend><h1>Sending your list</h1></legend>
>-                                    <fieldset>
>+                                    <fieldset class="brief">
>+                                        <legend><h1>Sending your list</h1></legend>
>                                         <label for="email">Email address:</label>
>-                                        <input type="text" id="email" name="email" size="43" class="focus" />
>+                                        <input type="text" id="email" name="email" size="43" class="focus form-control" />
> 
>                                         <label for="comment">Comment:</label>
>-                                        <textarea id="comment" name="comment" rows="4" cols="40"></textarea>
>+                                        <textarea id="comment" name="comment" rows="4" cols="40" class="form-control"></textarea>
> 
>                                         <input type="hidden" name="shelfid" value="[% shelfid | html %]" />
>                                     </fieldset>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32946: 146588 | 146696 | 146702 | 146703