Attachment 146667 Details for Bug 32566 – Bug 32566: Don't show "ILL request log" when IllLog is disabled

[patch] Bug 32566: Don't show "ILL request log" when IllLog is disabled

Bug-32566-Dont-show-ILL-request-log-when-IllLog-is.patch (text/plain), 2.27 KB, created by David Nind on 2023-02-15 09:25:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-02-15 09:25:13 UTC

Size: 2.27 KB

patch

obsolete

>From 972d3f8f70c1838a71dde73e60a9a2f9fb5e7cc9 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 9 Feb 2023 22:38:38 +0100
>Subject: [PATCH] Bug 32566: Don't show "ILL request log" when IllLog is
> disabled
>
>When the IllLog system preference is disabled there will be no
>log to view and the log will always appear empty.
>
>To test:
>1) Activate the IllModule system preference
>2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
>   https://wiki.koha-community.org/wiki/ILL_backends
>3) Go to the ILL module and add a new request
>4) The "ILL request log" entry in the toolbar should be visible
>5) Turn off the IllLog system preference
>6) Reload the page - the option should remain visible
>7) Apply patch
>8) Verify the link is now no longer visible after reload
>9) Re-activate the IllLog
>10) Verify the option now appears
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt  | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 5e6c7fc0dd..5319bbb868 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -599,10 +599,12 @@
>                             <span class="fa fa-eye"></span>
>                             Display supplier metadata
>                         </a>
>-                        <a title="ILL request log" id="ill-request-display-log" class="btn btn-default pull-right" href="#">
>-                            <span class="fa fa-calendar"></span>
>-                            ILL request log
>-                        </a>
>+                        [% IF Koha.Preference('IllLog') %]
>+                            <a title="ILL request log" id="ill-request-display-log" class="btn btn-default pull-right" href="#">
>+                                <span class="fa fa-calendar"></span>
>+                                ILL request log
>+                            </a>
>+                        [% END %]
>                     </div>
>                     <div class="ill-view-panel panel panel-default">
>                         <div class="panel-heading">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32566: 146454 | 146667 | 146901