Attachment 146691 Details for Bug 32970 – Bug 32970: Use KohaTable for display of batch item modification results

[patch] Bug 32970: Use KohaTable for display of batch item modification results

Bug-32970-Use-KohaTable-for-display-of-batch-item-.patch (text/plain), 2.40 KB, created by Nick Clemens (kidclamp) on 2023-02-15 15:32:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-02-15 15:32:30 UTC

Size: 2.40 KB

patch

obsolete

>From 9f82e5c7b78017be7a2690b3c0553c07ed2f3333 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 15 Feb 2023 15:30:04 +0000
>Subject: [PATCH] Bug 32970: Use KohaTable for display of batch item
> modification results
>
>This patch updates the code to use KohaTables to provide export of the
>batch modification results.
>
>Additionally, searching is added, and the first two columns are made
>searchable
>
>To test:
>1 - Perform a match item modification on several items
>2 - View the results of the background job
>3 - Apply patch
>4 - Reload page
>5 - Note you now have additional controls including 'search' and
>  'export'
>6 - Test searching and exporting
>7 - Confirm all work as expected
>---
> .../intranet-tmpl/prog/en/modules/admin/background_jobs.tt | 1 +
> koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js          | 7 +++----
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
>index c482d0d74c..8bcbc35579 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
>@@ -4,6 +4,7 @@
> [% USE KohaDates %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>+[% INCLUDE 'columns_settings.inc' %]
> <title>
>     [% IF op == 'view' %]
>         Details of job #[% job.id | html %] &rsaquo;
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>index 4d178d29d5..15bb86f4e8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>@@ -118,15 +118,14 @@ function hideAllColumns() {
> 
> $(document).ready(function () {
>     hideColumns();
>-    $("#itemst").dataTable($.extend(true, {}, dataTablesDefaults, {
>-        "sDom": 't',
>+    var items_table = KohaTable("itemst", {
>         "aoColumnDefs": [
>-            { "aTargets": [0, 1], "bSortable": false, "bSearchable": false },
>+            { "aTargets": [0, 1], "bSortable": false, "bSearchable": true },
>             { "aTargets": [0], "bVisible": false },
>             { "sType": "anti-the", "aTargets": ["anti-the"] }
>         ],
>         "bPaginate": false,
>-    }));
>+    });
>     $("#selectallbutton").click(function (e) {
>         e.preventDefault();
>         $("#itemst input:checkbox").each(function () {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32970: 146691 | 147965 | 148950 | 148951 | 149398 | 149399