Attachment 146700 Details for Bug 32975 – Bug 32975: Error in package.json's definition of css:build vs css:build:prod

[patch] Bug 32975: Error in package.json's definition of css:build vs css:build:prod

Bug-32975-Error-in-packagejsons-definition-of-cssb.patch (text/plain), 1.50 KB, created by Owen Leonard on 2023-02-15 20:00:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-02-15 20:00:08 UTC

Size: 1.50 KB

patch

obsolete

>From 562ac89dfc7f1de1aab67454a1b29383ead59391 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 15 Feb 2023 18:19:14 +0000
>Subject: [PATCH] Bug 32975: Error in package.json's definition of css:build vs
> css:build:prod
>
>The "css:build" command runs "gulp css && gulp css --view opac",
>processes that build CSS in a development context.
>
>The "css:build:prod" currently runs "gulp build && gulp css --view
>opac", which runs the production-oriented command "gulp build" (for the
>staff interface), but runs "gulp css --view opac" which is the same
>devel-environment command as above.
>
>It should be "gulp build && gulp build --view opac"
>
>To test, apply the patch and run the two commands and check these two
>files to confirm the difference:
>
>koha-tmpl/intranet-tmpl/prog/css/staff-global.css
>koha-tmpl/opac-tmpl/bootstra/css/opac.css
>
>"yarn css:build" should create unminimized versions of those files.
>"yarn css:build:prod" should create minimized versions.
>---
> package.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/package.json b/package.json
>index b9a295c51d..04ddc82309 100644
>--- a/package.json
>+++ b/package.json
>@@ -41,7 +41,7 @@
>   },
>   "scripts": {
>     "css:build": "gulp css && gulp css --view opac",
>-    "css:build:prod": "gulp build && gulp css --view opac",
>+    "css:build:prod": "gulp build && gulp build --view opac",
>     "css:watch": "gulp watch",
>     "js:build": "webpack --mode development",
>     "js:watch": "webpack --mode development --watch",
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32975: 146700 | 146701 | 146710