Attachment 146721 Details for Bug 32812 – Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl

[patch] Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl

Bug-32812-Fix-cataloguingvaluebuilderbarcodemanual.patch (text/plain), 1.11 KB, created by Marcel de Rooy on 2023-02-16 10:41:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-02-16 10:41:12 UTC

Size: 1.11 KB

patch

obsolete

>From 51e675a0770f4dc05ce47e8b6b6047dabe706b9c Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl
>Content-Type: text/plain; charset=utf-8
>
>Use event parameter instead of id.
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> cataloguing/value_builder/barcode_manual.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/cataloguing/value_builder/barcode_manual.pl b/cataloguing/value_builder/barcode_manual.pl
>index e809ca75f8..a7d015ba7a 100755
>--- a/cataloguing/value_builder/barcode_manual.pl
>+++ b/cataloguing/value_builder/barcode_manual.pl
>@@ -66,7 +66,8 @@ END_OF_JS
>     my $js  = <<END_OF_JS;
>     <script>
> 
>-    function Click$function_name(id) {
>+    function Click$function_name(event) {
>+        const id = event.data.id;
>         $scr
>             return false;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32812: 146070 | 146335 | 146721