Attachment 146742 Details for Bug 32878 – Bug 32878: (QA follow-up) Correct unit test

[patch] Bug 32878: (QA follow-up) Correct unit test

Bug-32878-QA-follow-up-Correct-unit-test.patch (text/plain), 1.29 KB, created by Nick Clemens (kidclamp) on 2023-02-16 16:13:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-02-16 16:13:38 UTC

Size: 1.29 KB

patch

obsolete

>From 0cd245ecbb4086672b57ab8887e55392e3be560d Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 16 Feb 2023 16:11:23 +0000
>Subject: [PATCH] Bug 32878: (QA follow-up) Correct unit test
>
>After the patch we fail on renewing a not for loan item with an item
>level hold.
>
>I don't find justification for why this should be renewable, so I just
>change the test expectation
>
>This needs another QA eye
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/Circulation.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 18e7ca271c..686f4c6cfe 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -672,7 +672,7 @@ subtest "CanBookBeRenewed tests" => sub {
>     # Items can't fill hold for reasons
>     $item_1->notforloan(1)->store;
>     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
>-    is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
>+    is( $renewokay, 0, 'Cannot renew, item is marked not for loan, but an item specific hold always blocks');
>     $item_1->set({notforloan => 0, itype => $itemtype })->store;
> 
>     # FIXME: Add more for itemtype not for loan etc.
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32878: 146145 | 146166 | 146740 | 146741 | 146742 | 146830 | 146833 | 146834 | 146835 | 148220 | 148223