Bugzilla – Attachment 146756 Details for
Bug 32816
Fix cataloguing/value_builder/cn_browser.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32816: Fix cataloguing/value_builder/cn_browser.pl
Bug-32816-Fix-cataloguingvaluebuildercnbrowserpl.patch (text/plain), 1.19 KB, created by
Julian Maurice
on 2023-02-17 10:09:36 UTC
(
hide
)
Description:
Bug 32816: Fix cataloguing/value_builder/cn_browser.pl
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2023-02-17 10:09:36 UTC
Size:
1.19 KB
patch
obsolete
>From 64d4237e71e47768e40a46fc3995c4f8569d96e6 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:51 +0100 >Subject: [PATCH] Bug 32816: Fix cataloguing/value_builder/cn_browser.pl > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > cataloguing/value_builder/cn_browser.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/value_builder/cn_browser.pl b/cataloguing/value_builder/cn_browser.pl >index 832ca51bf2..41e7c2d738 100755 >--- a/cataloguing/value_builder/cn_browser.pl >+++ b/cataloguing/value_builder/cn_browser.pl >@@ -33,8 +33,9 @@ my $builder = sub { > my $res = " > <script> > >-function Click$function_name(i) { >- q = document.getElementById('$params->{id}'); >+function Click$function_name(ev) { >+ ev.preventDefault(); >+ q = document.getElementById(ev.data.id); > window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+encodeURIComponent(q.value),\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\"); > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32816
:
146074
|
146341
|
146756
|
146853