Attachment 146758 Details for Bug 32821 – Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

[patch] Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

Bug-32821-Fix-cataloguingvaluebuilderstocknumberpl.patch (text/plain), 1.29 KB, created by Julian Maurice on 2023-02-17 10:09:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2023-02-17 10:09:59 UTC

Size: 1.29 KB

patch

obsolete

>From f4582e1a9e03a26f053706b5c04734bca9f8f039 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32821: Fix cataloguing/value_builder/stocknumber.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> cataloguing/value_builder/stocknumber.pl | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/stocknumber.pl b/cataloguing/value_builder/stocknumber.pl
>index 03dc79de06..51d7a1986c 100755
>--- a/cataloguing/value_builder/stocknumber.pl
>+++ b/cataloguing/value_builder/stocknumber.pl
>@@ -39,15 +39,19 @@ my $builder = sub {
>     my $js  = <<END_OF_JS;
> <script>
> 
>-function Focus$function_name(id, force) {
>+function set_stocknumber(id, force) {
>     if (\$('#' + id).val() == '' || force) {
>         \$('#' + id).val('$nextnum');
>     }
> }
> 
>+function Focus$function_name(event) {
>+    set_stocknumber(event.data.id, false);
>+}
>+
> function Click$function_name(event) {
>-    Focus$function_name(event.data.id, 1);
>-    return false;
>+    event.preventDefault();
>+    set_stocknumber(event.data.id, true);
> }
> </script>
> END_OF_JS
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32821: 146079 | 146344 | 146758 | 146851