Attachment 146761 Details for Bug 32825 – Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl

[patch] Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl

Bug-32825-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.59 KB, created by Julian Maurice on 2023-02-17 10:10:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2023-02-17 10:10:32 UTC

Size: 1.59 KB

patch

obsolete

>From f62a437a482fdfd7f705f99984c20ef88a6e9887 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>---
> cataloguing/value_builder/unimarc_field_105.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl
>index f0ff7f2dd8..35acbc0dce 100755
>--- a/cataloguing/value_builder/unimarc_field_105.pl
>+++ b/cataloguing/value_builder/unimarc_field_105.pl
>@@ -33,9 +33,10 @@ sub plugin_javascript {
>     my ($dbh,$record,$tagslib,$field_number) = @_;
>     my $res="
>     <script>
>-        function Clic$field_number() {
>-                defaultvalue=document.getElementById(\"$field_number\").value;
>-                window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_105.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_105\",'width=1200,height=400,toolbar=false,scrollbars=yes');
>+        function Clic$field_number(ev) {
>+                ev.preventDefault();
>+                defaultvalue=document.getElementById(ev.data.id).value;
>+                window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_105.pl&index=\" + ev.data.id + \"&result=\"+defaultvalue,\"unimarc_field_105\",'width=1200,height=400,toolbar=false,scrollbars=yes');
> 
>         }
>     </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32825: 146090 | 146761 | 146935 | 147361