Attachment 146762 Details for Bug 32826 – Bug 32826: Fix cataloguing/value_builder/unimarc_field_106.pl

[patch] Bug 32826: Fix cataloguing/value_builder/unimarc_field_106.pl

Bug-32826-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.53 KB, created by Julian Maurice on 2023-02-17 10:10:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2023-02-17 10:10:42 UTC

Size: 1.53 KB

patch

obsolete

>From 0b1f1b5e9f177e9a0151f5aaa9218140bcbd8368 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32826: Fix cataloguing/value_builder/unimarc_field_106.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>---
> cataloguing/value_builder/unimarc_field_106.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl
>index 7b91dd4410..4281987240 100755
>--- a/cataloguing/value_builder/unimarc_field_106.pl
>+++ b/cataloguing/value_builder/unimarc_field_106.pl
>@@ -32,9 +32,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_;
> my $function_name= "106".(int(rand(100000))+1);
> my $res="
> <script>
>-function Clic$field_number() {
>-        defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_106.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_106\",'width=500,height=400,toolbar=false,scrollbars=yes');
>+function Clic$field_number(ev) {
>+        ev.preventDefault();
>+        defaultvalue=document.getElementById(ev.data.id).value;
>+	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_106.pl&index=\" + ev.data.id + \"&result=\"+defaultvalue,\"unimarc_field_106\",'width=500,height=400,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32826: 146091 | 146762 | 146936 | 147365 | 147366