Attachment 146765 Details for Bug 32829 – Bug 32829: Fix cataloguing/value_builder/unimarc_field_115b.pl

[patch] Bug 32829: Fix cataloguing/value_builder/unimarc_field_115b.pl

Bug-32829-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.51 KB, created by Julian Maurice on 2023-02-17 10:11:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2023-02-17 10:11:13 UTC

Size: 1.51 KB

patch

obsolete

>From 3e204409e95d0884c9d209423c72e27e92fdc07b Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:52 +0100
>Subject: [PATCH] Bug 32829: Fix
> cataloguing/value_builder/unimarc_field_115b.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>---
> cataloguing/value_builder/unimarc_field_115b.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_115b.pl b/cataloguing/value_builder/unimarc_field_115b.pl
>index 901e73eb3e..af01dd763d 100755
>--- a/cataloguing/value_builder/unimarc_field_115b.pl
>+++ b/cataloguing/value_builder/unimarc_field_115b.pl
>@@ -32,9 +32,10 @@ sub plugin_javascript {
>     my ( $dbh, $record, $tagslib, $field_number ) = @_;
>     my $res = "
> <script>
>-function Clic$field_number() {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115b.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_115b\",'width=1200,height=600,toolbar=false,scrollbars=yes');
>+function Clic$field_number(ev) {
>+    ev.preventDefault();
>+    defaultvalue=document.getElementById(ev.data.id).value;
>+    window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115b.pl&index=\" + ev.data.id + \"&result=\"+defaultvalue,\"unimarc_field_115b\",'width=1200,height=600,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32829: 146094 | 146765 | 146939 | 147370