Attachment 146848 Details for Bug 32814 – Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

[patch] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

Bug-32814-Fix-cataloguingvaluebuildercallnumber-KU.patch (text/plain), 1.35 KB, created by Kyle M Hall (khall) on 2023-02-17 13:54:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-02-17 13:54:14 UTC

Size: 1.35 KB

patch

obsolete

>From 1dd4792d084e62d9928d4fbea0344b81730f2952 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> cataloguing/value_builder/callnumber-KU.pl | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/value_builder/callnumber-KU.pl b/cataloguing/value_builder/callnumber-KU.pl
>index 37b7e16d00..d6327a5306 100755
>--- a/cataloguing/value_builder/callnumber-KU.pl
>+++ b/cataloguing/value_builder/callnumber-KU.pl
>@@ -46,8 +46,9 @@ my $builder = sub {
>     my ( $params ) = @_;
>     my $res="
>     <script>
>-        function Click$params->{id}() {
>-                var code = document.getElementById('$params->{id}');
>+        function Click$params->{id}(ev) {
>+                ev.preventDefault();
>+                var code = document.getElementById(ev.data.id);
>                 var url = '../cataloguing/plugin_launcher.pl?plugin_name=callnumber-KU.pl&code=' + code.value;
>                 var req = \$.get(url);
>                 req.done(function(resp){
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32814: 146072 | 146342 | 146755 | 146848