Attachment 146853 Details for Bug 32816 – Bug 32816: Fix cataloguing/value_builder/cn_browser.pl

[patch] Bug 32816: Fix cataloguing/value_builder/cn_browser.pl

Bug-32816-Fix-cataloguingvaluebuildercnbrowserpl.patch (text/plain), 1.24 KB, created by Kyle M Hall (khall) on 2023-02-17 15:19:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-02-17 15:19:38 UTC

Size: 1.24 KB

patch

obsolete

>From 46769d5894741a204a714a9ec851c5f47141fdc5 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32816: Fix cataloguing/value_builder/cn_browser.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> cataloguing/value_builder/cn_browser.pl | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/value_builder/cn_browser.pl b/cataloguing/value_builder/cn_browser.pl
>index 832ca51bf2..41e7c2d738 100755
>--- a/cataloguing/value_builder/cn_browser.pl
>+++ b/cataloguing/value_builder/cn_browser.pl
>@@ -33,8 +33,9 @@ my $builder = sub {
>     my $res = "
> <script>
> 
>-function Click$function_name(i) {
>-    q = document.getElementById('$params->{id}');
>+function Click$function_name(ev) {
>+    ev.preventDefault();
>+    q = document.getElementById(ev.data.id);
>     window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+encodeURIComponent(q.value),\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\");
> }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32816: 146074 | 146341 | 146756 | 146853