Attachment 146869 Details for Bug 32999 – Bug 32999: Click handler to show QR code in OPAC lacks preventDefault

[patch] Bug 32999: Click handler to show QR code in OPAC lacks preventDefault

Bug-32999-Click-handler-to-show-QR-code-in-OPAC-la.patch (text/plain), 1.70 KB, created by Lucas Gass (lukeg) on 2023-02-17 16:50:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-02-17 16:50:13 UTC

Size: 1.70 KB

patch

obsolete

>From 4c6240cbeaecb8aa3e53de98ff5ce9a2846da144 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 17 Feb 2023 16:07:36 +0000
>Subject: [PATCH] Bug 32999: Click handler to show QR code in OPAC lacks
> preventDefault
>
>This patch adds "preventDefault()" to the click handler for showing
>the bibliographic detail QR code. This prevents the page from scrolling
>to the top when the user clicks the link.
>
>To test, apply the patch and make sure the OPACDetailQRCode system
>preference is enabled.
>
>Locate a bibliographic record and view the detail page. If necessary,
>reduce the size of your browser window so that you have to scroll down
>a bit to bring the "Send to device" menu item into view in the sidebar.
>Click the link to confirm that it shows the QR code and that the page
>doesn't jump to the top.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index c6fb1c26c6..61eae02a36 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1680,7 +1680,8 @@
>                     document.getElementById("qrcode").appendChild( qrcode );
>                 }
> 
>-                $(".show_qrcode").on("click", function(){
>+                $(".show_qrcode").on("click", function(e){
>+                    e.preventDefault();
>                     var qrcodeImg = $("#qrcode");
>                     if( qrcodeImg.hasClass("d-none") ){
>                         qrcodeImg.removeClass("d-none");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32999: 146857 | 146869 | 146900