Attachment 146903 Details for Bug 32021 – Bug 32021: Don't show 'appear in position' for Pages

[patch] Bug 32021: Don't show 'appear in position' for Pages

Bug-32021-Dont-show-appear-in-position-for-Pages.patch (text/plain), 1.64 KB, created by Kyle M Hall (khall) on 2023-02-17 18:35:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-02-17 18:35:52 UTC

Size: 1.64 KB

patch

obsolete

>From d1262196a6c6bd0eb0840f5a67f09ca9cdfd015b Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Wed, 15 Feb 2023 14:58:33 +1300
>Subject: [PATCH] Bug 32021: Don't show 'appear in position' for Pages
>
>The 'Appear in position' option isn't relevant for Pages, so we should
>hide it when not adding or modifying a Page.
>
>To test:
>
>1) Add a new Page
>2) Confirm the 'Appear in position' option does not show
>3) Add a new News item or HTML customisation
>4) Confirm the 'Appear in position' option DOES show
>
>Sponsored-by: Catalyst IT
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/additional-contents.tt  | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>index 30b0103a80..d2e9dd48f2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>@@ -256,6 +256,7 @@
>                         [% END %]
>                     </div>
>                 </li>
>+                [% UNLESS category == 'pages' %]
>                 <li>
>                     <label for="number">Appear in position: </label>
>                     [% IF ( additional_content.number ) %]
>@@ -264,6 +265,7 @@
>                         <input id="number" size="3" name="number" type="text" />
>                     [% END %]
>                 </li>
>+                [% END %]
>             </ol>
>         </fieldset>
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32021: 146656 | 146704 | 146734 | 146903