Bugzilla – Attachment 146946 Details for
Bug 33012
Accessibility: Some navigation items in OPAC cannot be accessed by keyboard (search history, log out)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33012: Remove tabindex from logout button
Bug-33012-Remove-tabindex-from-logout-button.patch (text/plain), 1.64 KB, created by
Marcel de Rooy
on 2023-02-20 11:46:56 UTC
(
hide
)
Description:
Bug 33012: Remove tabindex from logout button
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-02-20 11:46:56 UTC
Size:
1.64 KB
patch
obsolete
>From 252b2e15d245c0073a839bd920fbdf4400ee31c7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 20 Feb 2023 11:40:20 +0000 >Subject: [PATCH] Bug 33012: Remove tabindex from logout button >Content-Type: text/plain; charset=utf-8 > >Note: This is a trivial edit. But there is another logout link >too in masthead with js-hide class and tabindex -1 which is >rather mysterious to me ;) > >Test plan: >Login on OPAC. >Try to logout by tabbing to Logout button. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 941805f7a6..ab5988de4d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -121,7 +121,7 @@ > <a class="clearsh" href="/cgi-bin/koha/opac-search-history.pl?action=delete" title="Delete your search history"><i class="fa fa-trash" aria-hidden="true"></i> Clear</a> > </p> > [% END %] >- <a tabindex="-1" role="menuitem" class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> >+ <a role="menuitem" class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> > </div> > </div> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33012
:
146946
|
181509
|
181836
|
181837
|
181838
|
181839
|
181844
|
181845
|
181873