Attachment 146958 Details for Bug 33003 – Bug 33003: Show the vendor type on vendor detail page

[patch] Bug 33003: Show the vendor type on vendor detail page

Bug-33003-Show-the-vendor-type-on-vendor-detail-pa.patch (text/plain), 2.66 KB, created by Caroline Cyr La Rose on 2023-02-20 14:14:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2023-02-20 14:14:20 UTC

Size: 2.66 KB

patch

obsolete

>From 03938d86e7e24dd74833a8ffd79480a168a37931 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 18 Feb 2023 10:25:04 +0000
>Subject: [PATCH] Bug 33003: Show the vendor type on vendor detail page
>
>When using an authorised value VENDOR_TYPE for the
>vendor type, we should show the AV description
>everywhere instead of the code. It already works on
>the vendor search, but not on the vendor detail page.
>With this patch it will also work there.
>
>To test:
>1. Add at least one authorized value in VENDOR_TYPE
>   1.1. Go to Administration > Authorized values
>   1.2. Search for VENDOR_TYPE
>   1.3. Click 'Add'
>   1.4. Fill out the form
>        - Authorized value: BOOK
>        - Description: Print books
>   1.5. Click 'Save'
>2. Add a new vendor
>   2.1. Go to Acquisitions
>   2.2. Click 'New vendor'
>   2.3. Fill out the form
>        - Name: ABC Bookstore
>        - Vendor type: Print books
>   2.4. Click 'Save'
>3. Go to the vendor page
>   3.1. Click on the vendor name
>   --> The value in "Type" is BOOK, it should be "Print books"
>4. Apply patch
>   4.1. Repeat test, now it should show the description
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>index 0a49619121..9dd49954e9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>@@ -1,6 +1,7 @@
> [% USE raw %]
> [% USE Asset %]
> [% USE KohaDates %]
>+[% USE AuthorisedValues %]
> [% BLOCK edit_contact %]
>     <ol id="contact-form">
>         <input type="hidden" name="contact_id" value="[% contact.id | html %]" />
>@@ -306,7 +307,10 @@
>             <div class="col-sm-6">
>                 <div id="supplier-company-details" class="page-section">
>                     <h2>Vendor details</h2>
>-                    <p><span class="label">Type: </span>[% type | html %]</p>
>+                    <p>
>+                        <span class="label">Type: </span>
>+                        [% IF (type) %][% AuthorisedValues.GetByCode( 'VENDOR_TYPE', type ) | html %][% END %]
>+                    </p>
>                     <p><span class="label">Company name: </span>[% name | html %]</p>
>                     <p><span class="label">Postal address: </span>[% postal | html %]</p>
>                     <p><span class="label">Physical address: </span>[% address1 | html %][% address2 | html %][% address3 | html %][% address4 | html %]</p>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33003: 146910 | 146911 | 146920 | 146958 | 147212 | 147222