Bugzilla – Attachment 147148 Details for
Bug 32476
Add caching for relatively expensive patron methods
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32092: fix tests
Bug-32092-fix-tests.patch (text/plain), 1.47 KB, created by
David Gustafsson
on 2023-02-22 13:45:20 UTC
(
hide
)
Description:
Bug 32092: fix tests
Filename:
MIME Type:
Creator:
David Gustafsson
Created:
2023-02-22 13:45:20 UTC
Size:
1.47 KB
patch
obsolete
>From a1755f908441421cb82377bd9d380d3b77f55f14 Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Wed, 22 Feb 2023 14:44:52 +0100 >Subject: [PATCH] Bug 32092: fix tests > >https://bugs.koha-community.org/show_bug.cgi?id=32476 >--- > t/db_dependent/Koha/CirculationRules.t | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/t/db_dependent/Koha/CirculationRules.t b/t/db_dependent/Koha/CirculationRules.t >index 18c8653523f..86bd7e1daec 100755 >--- a/t/db_dependent/Koha/CirculationRules.t >+++ b/t/db_dependent/Koha/CirculationRules.t >@@ -580,9 +580,13 @@ subtest 'get_onshelfholds_policy() tests' => sub { > } > ); > >+ my $memory_cache = Koha::Cache::Memory::Lite->get_instance; >+ $memory_cache->flush(); >+ > is( $circ_rules->get_onshelfholds_policy({ item => $item }), 1, 'If rule_value is set on a matching rule, return it' ); > # Delete the rule (i.e. get_effective_rule returns undef) > $circ_rules->delete; >+ $memory_cache->flush(); > is( $circ_rules->get_onshelfholds_policy({ item => $item }), 0, 'If no matching rule, fallback to 0' ); > > $schema->storage->txn_rollback; >@@ -853,6 +857,7 @@ subtest 'get_lostreturn_policy() tests' => sub { > ) > ->next > ->delete; >+ $memory_cache->flush(); > is_deeply( Koha::CirculationRules->get_lostreturn_policy( $params ), > { lostreturn => 'refund', processingreturn => 'refund' },'No rule for branch, no default rule, fallback default (refund)'); > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32476
:
144626
|
144627
|
144744
|
144770
|
144771
|
145036
|
145037
|
147145
|
147148
|
150778
|
150779
|
157241
|
157258
|
157259
|
162537
|
162538
|
162539