Bugzilla – Attachment 147189 Details for
Bug 31051
Show patron's 'savings' on the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31051: Fix test
Bug-31051-Fix-test.patch (text/plain), 2.10 KB, created by
Jonathan Druart
on 2023-02-23 08:13:10 UTC
(
hide
)
Description:
Bug 31051: Fix test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-02-23 08:13:10 UTC
Size:
2.10 KB
patch
obsolete
>From 7a4e5327bf9ff9f77d87feffe66ba53ec0e7c564 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Feb 2023 09:12:04 +0100 >Subject: [PATCH] Bug 31051: Fix test > >When savings ends with a "0" > >koha_1 | # Failed test 'Savings correctly calculated from current issues' >koha_1 | # at t/db_dependent/Koha/Patron.t line 1380. >koha_1 | # got: '34583.70' >koha_1 | # expected: '34583.7' >koha_1 | >koha_1 | # Failed test 'Savings correctly calculated from current and old issues' >koha_1 | # at t/db_dependent/Koha/Patron.t line 1385. >koha_1 | # got: '34583.70' >koha_1 | # expected: '34583.7' >koha_1 | # Looks like you failed 2 tests of 4. >koha_1 | >koha_1 | # Failed test 'get_savings tests' >koha_1 | # at t/db_dependent/Koha/Patron.t line 1388. >koha_1 | # Looks like you failed 1 test of 20. >koha_1 | [00:07:57] t/db_dependent/Koha/Patron.t >--- > t/db_dependent/Koha/Patron.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t >index f0910bd9591..c25b8c49b65 100755 >--- a/t/db_dependent/Koha/Patron.t >+++ b/t/db_dependent/Koha/Patron.t >@@ -1377,12 +1377,12 @@ subtest 'get_savings tests' => sub { > AddIssue( $patron->unblessed, $item2->barcode ); > > my $savings = $patron->get_savings; >- is( $savings, $item1->replacementprice + $item2->replacementprice, "Savings correctly calculated from current issues" ); >+ is( $savings + 0, $item1->replacementprice + $item2->replacementprice, "Savings correctly calculated from current issues" ); > > AddReturn( $item2->barcode, $item2->homebranch ); > > $savings = $patron->get_savings; >- is( $savings, $item1->replacementprice + $item2->replacementprice, "Savings correctly calculated from current and old issues" ); >+ is( $savings + 0, $item1->replacementprice + $item2->replacementprice, "Savings correctly calculated from current and old issues" ); > > $schema->storage->txn_rollback; > }; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31051
:
136564
|
136664
|
136698
|
136699
|
136770
|
136772
|
136773
|
136779
|
136781
|
139100
|
139101
|
139102
|
139408
|
139409
|
139410
|
139911
|
139912
|
139913
|
139914
|
139937
|
143384
|
144082
|
144759
|
144760
|
144761
|
144762
|
144763
|
146431
|
146432
| 147189 |
147190