Attachment 147207 Details for Bug 32159 – Bug 32159: Fix heading hierarchy on uncertain prices page

[patch] Bug 32159: Fix heading hierarchy on uncertain prices page

Bug-32159-Fix-heading-hierarchy-on-uncertain-price.patch (text/plain), 2.16 KB, created by Jonathan Druart on 2023-02-23 09:43:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-02-23 09:43:29 UTC

Size: 2.16 KB

patch

obsolete

>From f7c0c18ab17e4479322f144b4050bb84e4b9755f Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 9 Feb 2023 22:52:07 +0100
>Subject: [PATCH] Bug 32159: Fix heading hierarchy on uncertain prices page
>
>This makes sure we don't have 2 level 1 headings on the same page.
>
>To test:
>* Create a new order for a basket in the acq module,
>  make sure the uncertain price checkbox is checked bevor saving
>* Go to uncertain prices using the link in the toolbar on the
>  basket summary page
>* Verify that there are 2 almost identical h1 headings and a "/ Fax:"
>  reference at the top of the page
>* Apply patch
>* Verify that we now have one level 1 heading and a level 2 heading
>  for each section. The fax reference is also gone.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt    | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>index eb60667e7e3..0cb91a3baed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>@@ -65,7 +65,7 @@
>                     [% bookselleraddress4 | html %]
>                 </p>
>                 <p><strong>Phone: </strong>
>-                    [% booksellerphone | html %] / Fax:
>+                    [% booksellerphone | html %]
>                 <dl>
>                     [% FOREACH contact IN contacts %]
>                         <dt><strong>Contact: </strong></dt>
>@@ -85,9 +85,8 @@
>             </div> 
>         [% END %]
> 
>-        <h1>Orders with uncertain prices</h1>
>-
>         <div class="page-section">
>+            <h2>Order lines with uncertain prices</h2>
>             <form action="[% scriptname | html %]" method="post">
>                 <input type="hidden" name="booksellerid" value="[% booksellerid | html %]" />
>                 <label for="owner">Orders from:</label>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32159: 146455 | 146646 | 146907 | 147207