Attachment 147220 Details for Bug 32492 – Bug 32492: Add IDs to the rows of the patron messaging table in OPAC and staff interface

[patch] Bug 32492: Add IDs to the rows of the patron messaging table in OPAC and staff interface

Bug-32492-Add-IDs-to-the-rows-of-the-patron-messag.patch (text/plain), 3.22 KB, created by Jonathan Druart on 2023-02-23 10:46:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-02-23 10:46:50 UTC

Size: 3.22 KB

patch

obsolete

>From 0190def7499d1d3bbed75346cd8da47ee6bb25f8 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 10 Feb 2023 23:28:40 +0100
>Subject: [PATCH] Bug 32492: Add IDs to the rows of the patron messaging table
> in OPAC and staff interface
>
>Sometimes you want to hide notice from the messaging options
>becaue the library is not using it. With this patch, we'll
>have unique IDs on the <tr> to do so easily.
>
>To test:
>* Look at the messaging preferences
> * in the OPAC messaging tab
> * in the staff interface details tab
> * in the staff interface patron edit form
>* Verify there are no classes or IDs on the rows or other elements
>* Apply patch
>* Verify there are nice IDs now on the table rows (tr elements)
> for each message.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/includes/messaging-preference-form.inc | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>index b27cc00af5f..6290f6f7a91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>@@ -18,7 +18,7 @@
> [% FOREACH messaging_preference IN messaging_preferences %]
> [% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %]
> [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %]
>- <tr>
>+ <tr id="[% messaging_preference.message_name _ "_message" | lower %]">
> <td>[% IF ( messaging_preference.Item_Due ) %]Item due
> [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice
> [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 598ba1f20a1..f7b52b53540 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -62,7 +62,7 @@
> [% FOREACH messaging_preference IN messaging_preferences %]
> [% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %]
> [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %]
>- <tr>
>+ <tr id="[% messaging_preference.message_name _ "_message" | lower %]">
> <td>[% IF ( messaging_preference.Item_Due ) %]Item due
> [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice
> [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32492: 146525 | 146580 | 146581 | 147217 | 147218 | 147220 | 147221