Bugzilla – Attachment 147236 Details for
Bug 32585
Followup on Bug 32583 - fix some variable references
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32585: (bug 32583 follow-up) Fix some variable references
Bug-32585-bug-32583-follow-up-Fix-some-variable-re.patch (text/plain), 1.49 KB, created by
Jonathan Druart
on 2023-02-23 14:35:43 UTC
(
hide
)
Description:
Bug 32585: (bug 32583 follow-up) Fix some variable references
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-02-23 14:35:43 UTC
Size:
1.49 KB
patch
obsolete
>From adffd9bb8694a5445f12f34fc634f19509be720b Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Fri, 6 Jan 2023 16:11:01 -0700 >Subject: [PATCH] Bug 32585: (bug 32583 follow-up) Fix some variable references > >Bug 32583 change the $item variable from a hash to an object. Trivial patch >to change some hash references to object method calls. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > catalogue/moredetail.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 46ac7f750a2..90c41a3a46f 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -169,12 +169,12 @@ foreach my $item (@items){ > > # item has a host number if its biblio number does not match the current bib > if ($item->biblionumber ne $biblionumber){ >- $item_info->{hostbiblionumber} = $item->{biblionumber}; >+ $item_info->{hostbiblionumber} = $item->biblionumber; > $item_info->{hosttitle} = $item->biblio->title; > } > > # FIXME The acquisition code below could be improved using methods from Koha:: objects >- my $order = GetOrderFromItemnumber( $item->{'itemnumber'} ); >+ my $order = GetOrderFromItemnumber( $item->itemnumber ); > $item_info->{'basketno'} = $order->{'basketno'}; > $item_info->{'orderdate'} = $order->{'entrydate'}; > if ($item_info->{'basketno'}){ >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32585
:
145115
|
145228
| 147236