Attachment 147280 Details for Bug 30931 – Bug 30931: (alternate) Display a hint in item editor that the dateaccessioned will be filled with current date if left blank

[patch] Bug 30931: (alternate) Display a hint in item editor that the dateaccessioned will be filled with current date if left blank

Bug-30931-alternate-Display-a-hint-in-item-editor-.patch (text/plain), 4.87 KB, created by Alex Buckley on 2023-02-24 04:33:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2023-02-24 04:33:33 UTC

Size: 4.87 KB

patch

obsolete

>From c29ec4c9c877111b1e944f47e28f8a80db66deb4 Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Tue, 7 Jun 2022 23:48:42 +1200
>Subject: [PATCH] Bug 30931: (alternate) Display a hint in item editor that the
> dateaccessioned will be filled with current date if left blank
>
>This hint WILL show when:
>- Adding a new item
>- Receiving a serial issue
>- Ordering from a purchase suggestion (Acquisitions module)
>- Ordering from a staged file (Acquisitions module)
>
>This hint WILL NOT show when:
>- Batch modifying items
>- Editing existing items
>
>Test plan:
>1. Apply patch
>
>2. Add an item to a biblio record. Notice there is a hint message for the
>952$d (date acquired) subfield.
>
>3. Edit an existing item. Notice there is no hint message displaying for the 952$d
>subfield.
>
>4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the 952$d subfield.
>
>5. Receive a serial (The subscription must be setup to create an item
>upon receival to test this).
>
>6. Notice there is a hint message displaying for the 952$d (Date acquired) subfield in both the main issue you are receiving and the supplemental issue form as well
>
>7. In the Acquisitions module place an order from a purchase suggestion.
>Confirm the hint message is displayed for the Date acquired field.
>
>8. In the Acquisitions module place an order from a staged file. Confirm
>the hint message is displayed for the Date acquired field.
>
>Sponsored-by: Catalyst IT
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc  | 7 +++++--
> .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt  | 3 +++
> .../prog/en/modules/services/itemrecorddisplay.tt          | 1 +
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>index 758c7ba8d0..98372f3aeb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>@@ -200,8 +200,11 @@
>                         </a>
>                     [% END %]
> 
>-                    <span class="hint" id="hint[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]"></span>
>-
>+                    [% IF (subfield.kohafield == 'items.dateaccessioned' && op == "additem") %]
>+                        <span class="hint" id="hint[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]">Today's date will be saved in this field if you leave it blank.[% del %]</span>
>+                    [% ELSE %]
>+                        <span class="hint" id="hint[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]"></span>
>+                    [% END %]
>                 </div>
>             </li>
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index fdea3ee1be..871d29d7cf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -273,6 +273,7 @@ $(document).ready(function() {
>                     </a>
>                 [% END %]
>                 [% IF ( iteminformatio.mandatory ) %] <span class="required">Required</span>[% END %]
>+                [% IF iteminformatio.kohafield == 'items.dateaccessioned' %] <span class="hint">Today's date will be saved in this field if you leave it blank.</span>[% END %]
>             </div></li>
> 
>         [% END %]</ol></div>
>@@ -425,6 +426,8 @@ $(document).ready(function() {
>                     </a>
>                 [% END %]
>                 [% IF ( iteminformatio.mandatory ) %] <span class="required">Required</span>[% END %]
>+		[% IF iteminformatio.kohafield == 'items.dateaccessioned' %] <span class="hint">Today's date will be saved in this field if you leave it blank.</span>[% END %]
>+
>         </div>
>        </li>[% END %]</ol>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
>index c8a3b1fd24..6e55e7f4a4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
>@@ -30,6 +30,7 @@
>         <input type="hidden" name="tag" value="[% iteminfo.tag | html %]" />
>         <input type="hidden" name="subfield" value="[% iteminfo.subfield | html %]" />
>         <input type="hidden" name="mandatory" value="[% iteminfo.mandatory | html %]" />
>+        [% IF (iteminfo.kohafield == 'items.dateaccessioned') %] <span class="hint">Today's date will be saved in this field if you leave it blank.</span>[% END %]
>         [% IF (iteminfo.mandatory) %] <span class="required">Required</span>[% END %]
>       </div>
>     </li>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30931: 135854 | 135855 | 136663 | 147280