Attachment 147287 Details for Bug 31611 – Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool

[patch] Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool

Bug-31611-Clearly-highlight-biblios-that-cannot-be.patch (text/plain), 2.38 KB, created by Marcel de Rooy on 2023-02-24 09:42:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-02-24 09:42:05 UTC

Size: 2.38 KB

patch

obsolete

>From 2722c58ea51070518ad2521e7091832387f92592 Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Fri, 23 Sep 2022 11:16:22 +1200
>Subject: [PATCH] Bug 31611: Clearly highlight biblios that cannot be deleted
> in the Batch record deletion tool
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>1. Apply patch
>2. Check out an item
>3. Go to: 'Cataloguing' > 'Batch record deletion'
>4. Into the 'Enter a list of record numbers' area paste in the
>biblionumber belonging to the checked-out item and that of a biblio without checked out items
>5. Submit the form
>6. Observe the row of the biblio with checked-out items is highlighted yellow, with a
>red cross in the first column
>7. Hover over the red cross to see the reason why the biblio cannot be
>deleted
>8. Observe the row of the biblio without checked-out items is not
>highlighted yellow, and does have a checkbox in the first column
>9. Click 'Delete selected records'
>10. Confirm the biblio without checked-out items is successfully deleted
>
>Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/modules/tools/batch_delete_records.tt         | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>index 3a0555329b..8b01818980 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>@@ -305,12 +305,12 @@
> 
>           $("#selectall").click();
> 
>+          //Show a red cross if a biblio cannot be deleted
>           [% IF recordtype == 'biblio' %]
>             $(".records input:checkbox[data-issues!='0']").each(function(){
>-              $(this).attr('title', MSG_CANNOT_BE_DELETED)
>-              $(this).prop('disabled', true);
>-              $(this).prop('checked', false);
>-              $(this).parents('tr').find('td').css('background-color', '#ffff99');
>+              $(this).parents('tr').find('td').css('background-color', '#ffff99')
>+              $(this).replaceWith("<span class='error'><i class='fa fa-times fa-lg'></i></span>")
>+              $(".records i").attr('title', MSG_CANNOT_BE_DELETED)
>             });
>           [% END %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31611: 140878 | 140879 | 140880 | 144888 | 144889 | 144890 | 144897 | 144898 | 147286 | 147287