Attachment 147310 Details for Bug 32939 – Bug 32939: Introduce count

[patch] Bug 32939: Introduce count

Bug-32939-Introduce-count.patch (text/plain), 2.21 KB, created by Nick Clemens (kidclamp) on 2023-02-24 12:22:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-02-24 12:22:36 UTC

Size: 2.21 KB

patch

obsolete

>From 46e6eca20f550ff19a988f5afd604c2eba41de46 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 15 Feb 2023 10:43:46 +0100
>Subject: [PATCH] Bug 32939: Introduce count
>
>Not used yet, will replace myFetchTotal
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../prog/js/vue/fetch/http-client.js          | 26 ++++++++++++++++---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js
>index d1b5a917b9..476440dadd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js
>@@ -8,13 +8,18 @@ class HttpClient {
>         };
>     }
> 
>-    async _fetchJSON(endpoint, headers = {}, options = {}) {
>+    async _fetchJSON(
>+        endpoint,
>+        headers = {},
>+        options = {},
>+        return_response = false
>+    ) {
>         let res;
>         await fetch(this._baseURL + endpoint, {
>             ...options,
>             headers: { ...this._headers, ...headers },
>         })
>-            .then(this.checkError)
>+            .then((response) => this.checkError(response, return_response))
>             .then(
>                 (result) => {
>                     res = result;
>@@ -60,6 +65,21 @@ class HttpClient {
>         });
>     }
> 
>+    count(params = {}) {
>+        let res;
>+        this._fetchJSON(params.endpoint, params.headers, 1).then(
>+            (response) => {
>+                if (response) {
>+                    res = response.headers.get("X-Total-Count");
>+                }
>+            },
>+            (error) => {
>+                setError(error.toString());
>+            }
>+        );
>+        return res;
>+    }
>+
>     checkError(response, return_response = 0) {
>         if (response.status >= 200 && response.status <= 299) {
>             return return_response ? response : response.json();
>@@ -69,8 +89,6 @@ class HttpClient {
>             throw Error("%s (%s)".format(response.statusText, response.status));
>         }
>     }
>-
>-    //TODO: Implement count method
> }
> 
> export default HttpClient;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32939: 146470 | 146509 | 146642 | 146644 | 146645 | 146668 | 146669 | 146670 | 146671 | 146672 | 146674 | 146675 | 146676 | 146677 | 146678 | 146679 | 146680 | 146681 | 146682 | 147029 | 147030 | 147031 | 147032 | 147033 | 147034 | 147035 | 147036 | 147037 | 147038 | 147039 | 147040 | 147041 | 147042 | 147043 | 147044 | 147056 | 147057 | 147059 | 147060 | 147061 | 147062 | 147063 | 147064 | 147065 | 147066 | 147067 | 147068 | 147069 | 147070 | 147071 | 147072 | 147073 | 147306 | 147307 | 147308 | 147309 | 147310 | 147311 | 147312 | 147313 | 147314 | 147315 | 147316 | 147317 | 147318 | 147319 | 147320 | 147321 | 147322 | 147332 | 149441