Bugzilla – Attachment 147331 Details for
Bug 33055
SIP2 adding incorrect fines blocked message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked
Bug-33055-bug-32624-follow-up-Dont-send-a-screen-m.patch (text/plain), 1.80 KB, created by
Martin Renvoize (ashimema)
on 2023-02-24 13:30:39 UTC
(
hide
)
Description:
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-02-24 13:30:39 UTC
Size:
1.80 KB
patch
obsolete
>From 5f303a51235cb2ba2694041136be66e52d3c333d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 23 Feb 2023 15:33:00 +0000 >Subject: [PATCH] Bug 33055: (bug 32624 follow-up) Don't send a screen message > if not blocked > >To test: >0 - Apply first patch >1 - prove -v t/db_dependent/SIP/Patron.t >2 - It fails >3 - Apply second patch >4 - prove -v t/db_dependent/SIP/Patron.t >5 - It passes! > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/SIP/ILS/Patron.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 88afb4ac00..e5542bfb2b 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -90,11 +90,11 @@ sub new { > } elsif ( $noissueschargeguarantorswithguarantees ) { > $fines_amount += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 0 }); > $fine_blocked ||= $fines_amount > $noissueschargeguarantorswithguarantees; >- $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on related accounts"; >+ $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on related accounts" if $fine_blocked; > } elsif ( $noissueschargeguarantees ) { > $fines_amount += $patron->relationships_debt({ include_guarantors => 0, only_this_guarantor => 0, include_this_patron => 0 }); > $fine_blocked ||= $fines_amount > $noissueschargeguarantees; >- $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on guaranteed accounts"; >+ $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on guaranteed accounts" if $fine_blocked; > } > > my $circ_blocked =( C4::Context->preference('OverduesBlockCirc') ne "noblock" && defined $flags->{ODUES}->{itemlist} ) ? 1 : 0; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33055
:
147258
|
147259
|
147330
|
147331
|
147507
|
147508