Attachment 147351 Details for Bug 32820 – Bug 32820: Fix cataloguing/value_builder/stocknumberAV.pl

[patch] Bug 32820: Fix cataloguing/value_builder/stocknumberAV.pl

Bug-32820-Fix-cataloguingvaluebuilderstocknumberAV.patch (text/plain), 1.70 KB, created by Nick Clemens (kidclamp) on 2023-02-24 16:11:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-02-24 16:11:26 UTC

Size: 1.70 KB

patch

obsolete

>From 8101ade8dd2f7eac3706e68b7f98cdcebee18d64 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32820: Fix cataloguing/value_builder/stocknumberAV.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> cataloguing/value_builder/stocknumberAV.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/stocknumberAV.pl b/cataloguing/value_builder/stocknumberAV.pl
>index 793cf1066a..c158ec7688 100755
>--- a/cataloguing/value_builder/stocknumberAV.pl
>+++ b/cataloguing/value_builder/stocknumberAV.pl
>@@ -47,8 +47,9 @@ my $builder = sub {
>     my ( $params ) = @_;
>     my $res = qq{
>     <script>
>-        function Click$params->{id}() {
>-                var code = document.getElementById('$params->{id}');
>+        function Click$params->{id}(ev) {
>+                ev.preventDefault();
>+                var code = document.getElementById(ev.data.id);
>                 \$.ajax({
>                     url: '/cgi-bin/koha/cataloguing/plugin_launcher.pl',
>                     type: 'POST',
>@@ -57,7 +58,7 @@ my $builder = sub {
>                         'code'    : code.value,
>                     },
>                     success: function(data){
>-                        var field = document.getElementById('$params->{id}');
>+                        var field = document.getElementById(ev.data.id);
>                         field.value = data;
>                         return 1;
>                     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32820: 146078 | 146757 | 146929 | 147351