Attachment 147358 Details for Bug 32823 – Bug 32823: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl

[patch] Bug 32823: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl

Bug-32823-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.35 KB, created by Nick Clemens (kidclamp) on 2023-02-24 16:33:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-02-24 16:33:40 UTC

Size: 1.35 KB

patch

obsolete

>From 17b734bb2b0c73c603955e8a6786c9786710bf6b Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:51 +0100
>Subject: [PATCH] Bug 32823: Fix
> cataloguing/value_builder/unimarc_field_100_authorities.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> cataloguing/value_builder/unimarc_field_100_authorities.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_100_authorities.pl b/cataloguing/value_builder/unimarc_field_100_authorities.pl
>index f15185c430..a1a6b87be7 100755
>--- a/cataloguing/value_builder/unimarc_field_100_authorities.pl
>+++ b/cataloguing/value_builder/unimarc_field_100_authorities.pl
>@@ -30,7 +30,9 @@ sub plugin_javascript {
>     my ( $dbh, $record, $tagslib, $field_number ) = @_;
>     my $res           = "
>         <script>
>-            function Clic$field_number(i) {
>+            function Clic$field_number(event) {
>+                event.preventDefault();
>+                const i = event.data.id;
>                 var defaultvalue;
>                 try {
>                     defaultvalue = document.getElementById(i).value;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32823: 146081 | 146759 | 146931 | 147358