Attachment 147432 Details for Bug 33060 – Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

[patch] Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

Bug-33060-Fix-yesno-setting-to-10-in-system-prefer.patch (text/plain), 2.66 KB, created by Owen Leonard on 2023-02-27 12:02:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-02-27 12:02:38 UTC

Size: 2.66 KB

patch

obsolete

>From b54bd996784563173d5b4e7e63ebd04474690bed Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 23 Feb 2023 22:16:56 +0000
>Subject: [PATCH] Bug 33060: Fix yes/no setting to 1/0 in system preference
> YAML files
>
>Boolean system preferences need to use 1 and 0 for true and false,
>not yes and no now. This fixes a few occurences that have
>been added in the last release:
>
>* EnableItemGroups
>* EnableItemGroupHolds
>* ArticleRequestsOpacHostRedirection
>* UseLocationAsAQInSIP
>
>To test:
>* Make sure these preferences save to the db as 0/1 as expected.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../modules/admin/preferences/circulation.pref   | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index b3491e685f..e12abc7534 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -673,8 +673,8 @@ Circulation:
>         -
>             - pref: EnableItemGroups
>               choices:
>-                  yes: Enable
>-                  no: "Don't enable"
>+                  1: Enable
>+                  0: "Don't enable"
>             - the item groups feature to allow collecting groups of items on a record together.
>         -
>             - In the staff interface, split the holds queue into separate tables by
>@@ -688,8 +688,8 @@ Circulation:
>         -
>             - pref: EnableItemGroupHolds
>               choices:
>-                  yes: Enable
>-                  no: "Don't enable"
>+                  1: Enable
>+                  0: "Don't enable"
>             - the ability to place holds on item groups.
>         -
>             - If the holds queue is split, show librarians
>@@ -1234,8 +1234,8 @@ Circulation:
>         -
>             - pref: ArticleRequestsOpacHostRedirection
>               choices:
>-                  yes: Enable
>-                  no: Disable
>+                  1: Enable
>+                  0: Disable
>             - " redirection from child to host based on MARC21 773$w when the child has no items when requesting articles on the Opac."
>         -
>             - pref: ArticleRequestsLinkControl
>@@ -1356,8 +1356,8 @@ Circulation:
>             - Use
>             - pref: UseLocationAsAQInSIP
>               choices:
>-                  yes: permanent_location
>-                  no: homebranch
>+                  1: permanent_location
>+                  0: homebranch
>             - for AQ field in SIP protocol.
> 
>     Curbside pickup module:
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33060: 147274 | 147432 | 148230