Attachment 147444 Details for Bug 30846 – Bug 30846: (follow-up) Unit tests

[patch] Bug 30846: (follow-up) Unit tests

Bug-30846-follow-up-Unit-tests.patch (text/plain), 1.11 KB, created by Hammat wele on 2023-02-27 14:37:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hammat wele

Created: 2023-02-27 14:37:41 UTC

Size: 1.11 KB

patch

obsolete

>From c2f20db297852f0f10cccb16cf09c4efd60466d1 Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Mon, 27 Feb 2023 14:35:15 +0000
>Subject: [PATCH] Bug 30846: (follow-up) Unit tests
>
>---
> t/db_dependent/Reserves.t | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 3371c9539d..d59b236e06 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -1455,7 +1455,7 @@ $schema->storage->txn_rollback();
> 
> subtest 'IsAvailableForItemLevelRequest() tests' => sub {
> 
>-    plan tests => 2;
>+    plan tests => 3;
> 
>     $schema->storage->txn_begin;
> 
>@@ -1487,6 +1487,11 @@ subtest 'IsAvailableForItemLevelRequest() tests' => sub {
>         "Item not available for item-level hold because no effective item type"
>     );
> 
>+    my $item_1 = $builder->build_sample_item({ notforloan => -1 });
>+    ok(
>+        C4::Reserves::IsAvailableForItemLevelRequest( $item_1, $patron ),
>+        "Item not available for item-level hold because no effective item type"
>+    );
>     $schema->storage->txn_rollback;
> };
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30846: 145586 | 145660 | 147443 | 147444 | 151648 | 151649 | 153797 | 153798 | 154404