Bugzilla – Attachment 147456 Details for
Bug 32991
Improve our Dialog component and remove routes for deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates
Bug-32991-Fix-agreements-tests-with-new-dialog-ins.patch (text/plain), 1.94 KB, created by
Pedro Amorim
on 2023-02-27 15:26:46 UTC
(
hide
)
Description:
Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-02-27 15:26:46 UTC
Size:
1.94 KB
patch
obsolete
>From 1090fe0d2d8838c62e3f30affad7f9044cf652be Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 24 Feb 2023 16:06:31 +0000 >Subject: [PATCH] Bug 32991: Fix agreements tests with new dialog instead of > confirm delete page. Squash this later with other tests updates > >--- > t/cypress/integration/Agreements_spec.ts | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/t/cypress/integration/Agreements_spec.ts b/t/cypress/integration/Agreements_spec.ts >index d6b7ffcb30..ec316a62d2 100644 >--- a/t/cypress/integration/Agreements_spec.ts >+++ b/t/cypress/integration/Agreements_spec.ts >@@ -506,15 +506,14 @@ describe("Agreement CRUD operations", () => { > cy.get("#agreements_list table tbody tr:first") > .contains("Delete") > .click(); >- cy.get("#agreements_confirm_delete h2").contains("Delete agreement"); >- cy.contains("Agreement name: " + agreement.name); >+ cy.get(".dialog.alert.confirmation h1").contains("remove this agreement"); > > // Submit the form, get 500 > cy.intercept("DELETE", "/api/v1/erm/agreements/*", { > statusCode: 500, > error: "Something went wrong", > }); >- cy.contains("Yes, delete").click(); >+ cy.contains("Accept").click(); > cy.get("main div[class='dialog alert']").contains( > "Something went wrong: Error: Internal Server Error" > ); >@@ -524,7 +523,11 @@ describe("Agreement CRUD operations", () => { > statusCode: 204, > body: null, > }); >- cy.contains("Yes, delete").click(); >+ cy.get("#agreements_list table tbody tr:first") >+ .contains("Delete") >+ .click(); >+ cy.get(".dialog.alert.confirmation h1").contains("remove this agreement"); >+ cy.contains("Accept").click(); > cy.get("main div[class='dialog message']").contains( > "Agreement deleted" > ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32991
:
146828
|
146829
|
147051
|
147052
|
147053
|
147054
|
147082
|
147083
|
147281
|
147282
|
147291
|
147305
|
147350
|
147383
|
147384
|
147385
|
147387
|
147388
|
147389
|
147390
|
147391
|
147392
|
147393
|
147394
|
147429
|
147439
|
147445
|
147447
|
147448
|
147449
|
147450
|
147451
|
147452
|
147453
|
147454
|
147455
|
147456
|
147461
|
147483
|
147485
|
147486
|
147487
|
147542
|
147543
|
147544
|
147545
|
147546
|
147547
|
147548
|
147549
|
147550
|
147551
|
147552
|
147553
|
147554
|
147569
|
147573
|
147584
|
147588
|
147589
|
147590
|
147591
|
147592
|
147593
|
147594
|
147595
|
147596
|
147597
|
147598
|
147599
|
147600
|
147601
|
147602
|
147603
|
147604
|
147937
|
147938
|
147939
|
147940
|
147941
|
147942
|
147943
|
147944
|
147945
|
147946
|
147947
|
147948
|
147949
|
147950
|
147951