Bugzilla – Attachment 147695 Details for
Bug 30860
Performance: Add option for CanBookBeReserved to return all item values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30860: (follow-up) Remove repeated variable declaration
Bug-30860-follow-up-Remove-repeated-variable-decla.patch (text/plain), 904 bytes, created by
Nick Clemens (kidclamp)
on 2023-03-03 13:14:24 UTC
(
hide
)
Description:
Bug 30860: (follow-up) Remove repeated variable declaration
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-03-03 13:14:24 UTC
Size:
904 bytes
patch
obsolete
>From 853a3ca67453300430c227ea39f44917f4582ee1 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 3 Mar 2023 12:49:29 +0000 >Subject: [PATCH] Bug 30860: (follow-up) Remove repeated variable declaration > >--- > t/db_dependent/Reserves.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index ce647eebe7..9d0e109421 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -1770,7 +1770,7 @@ subtest 'CanBookBeReserved return_all_items tests' => sub { > t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 0); > $item_4->damaged(1)->store(); > $can_item_4_be = CanItemBeReserved($patron,$item_4); >- my $can_be_all = { >+ $can_be_all = { > %$can_book_be, > $item_1->itemnumber => $can_item_1_be, > $item_2->itemnumber => $can_item_2_be, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30860
:
135426
|
135427
|
135428
|
135429
|
144480
|
144481
|
144482
|
144483
|
144506
|
144507
|
144508
|
144509
|
145577
|
145578
|
145579
|
145580
|
145581
|
145582
|
145583
|
145584
|
147695
|
148562
|
148812
|
149124
|
149377