Bugzilla – Attachment 147698 Details for
Bug 31422
Library limitations might cause data loss when editing patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31422: [22.05.x] Add patron's current category to dropdown while editing
Bug-31422-2205x-Add-patrons-current-category-to-dr.patch (text/plain), 3.00 KB, created by
Nick Clemens (kidclamp)
on 2023-03-03 13:54:00 UTC
(
hide
)
Description:
Bug 31422: [22.05.x] Add patron's current category to dropdown while editing
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-03-03 13:54:00 UTC
Size:
3.00 KB
patch
obsolete
>From 3c56bb1a93d3497e9c0af71cab9fe0d517cceef4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 20 Oct 2022 14:53:33 +0000 >Subject: [PATCH] Bug 31422: [22.05.x] Add patron's current category to > dropdown while editing > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Bug 31422: (QA follow-up) Fix terminology and switch icon > >* fa-exclamation-circle looks more like 'info', but I feel this > should be more of a warning, so switched to fa-exclamation-triangle >* Changed branches to libraries in message > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/members/memberentrygen.tt | 3 +++ > members/memberentry.pl | 11 +++++++++++ > 2 files changed, 14 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 1a58a60751..1c16927c93 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -935,6 +935,9 @@ legend:hover { > [% END # /FOREACH categoryloo %] > [% END # /FOREACH typeloo %] > </select> >+ [% IF limited_category %] >+ <span style="float:right;" title="The patron's current category ([% patron_category.description | html %]) is limited to other libraries"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span> >+ [% END %] > <span class="required">Required</span> > </li> > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 344be77070..05559b869c 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -677,6 +677,17 @@ foreach my $category_type (qw(C A S P I X)) { > $no_categories = 0 if $patron_categories->count > 0; > > my @categoryloop; >+ unless ( (!defined $categorycode) || $patron_categories->find( $categorycode ) ){ >+ my $category = Koha::Patron::Categories->find( $categorycode ); >+ $template->param( limited_category => 1 ); >+ push @categoryloop, >+ { 'category_code' => $category->categorycode, >+ 'categoryname' => $category->description, >+ 'effective_min_password_length' => $category->effective_min_password_length, >+ 'effective_require_strong_password' => $category->effective_require_strong_password. >+ 'categorycodeselected' => 1 >+ }; >+ } > while ( my $patron_category = $patron_categories->next ) { > $categorycode = $patron_category->categorycode unless defined($categorycode); #If none passed in, select the first > push @categoryloop, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31422
:
142259
|
142285
|
143050
|
143051
| 147698